Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757515AbbEVR4c (ORCPT ); Fri, 22 May 2015 13:56:32 -0400 Received: from mail-qk0-f170.google.com ([209.85.220.170]:36772 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756693AbbEVR4a (ORCPT ); Fri, 22 May 2015 13:56:30 -0400 MIME-Version: 1.0 In-Reply-To: <1432252663-31318-10-git-send-email-ezequiel.garcia@imgtec.com> References: <1432252663-31318-1-git-send-email-ezequiel.garcia@imgtec.com> <1432252663-31318-10-git-send-email-ezequiel.garcia@imgtec.com> Date: Fri, 22 May 2015 10:56:29 -0700 X-Google-Sender-Auth: BKI8Q7Y-I5lMURvewX9qLgkgXQI Message-ID: Subject: Re: [PATCH 9/9] clk: pistachio: Correct critical clock list From: Andrew Bresticker To: Ezequiel Garcia Cc: Linux-MIPS , "linux-kernel@vger.kernel.org" , Mike Turquette , Stephen Boyd , James Hartley , Govindraj Raja , Damien Horsley , Kevin Cernekee , James Hogan Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 914 Lines: 21 On Thu, May 21, 2015 at 4:57 PM, Ezequiel Garcia wrote: > From: Damien Horsley > > Correct the critical clock list. The current one is wrong, and may > fail under some circumstances. > > Signed-off-by: Damien Horsley > Signed-off-by: Ezequiel Garcia The commit message could be more descriptive, e.g. explaining which additional clocks must be enabled at all times and why, especially since forcing on clocks form the clock driver is very much frowned upon unless absolutely necessary. Otherwise, Reviewed-by: Andrew Bresticker -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/