Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757592AbbEVR5M (ORCPT ); Fri, 22 May 2015 13:57:12 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:36871 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756894AbbEVR5H (ORCPT ); Fri, 22 May 2015 13:57:07 -0400 Date: Fri, 22 May 2015 18:56:51 +0100 From: Russell King - ARM Linux To: Maxime Coquelin Cc: Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , Stefan Agner , manabian@gmail.com, "linux-kernel@vger.kernel.org" , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , olof@lixom.net Subject: Re: [PATCH soc] ARM: use ARM_SINGLE_ARMV7M for ARMv7-M platforms Message-ID: <20150522175651.GL2067@n2100.arm.linux.org.uk> References: <1432161344-1930-1-git-send-email-stefan@agner.ch> <15864413.ed8EFg1NLl@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1327 Lines: 33 On Fri, May 22, 2015 at 05:29:20PM +0200, Maxime Coquelin wrote: > 2015-05-22 16:50 GMT+02:00 Arnd Bergmann : > > [one small request as I have four armv7-m folks on Cc already: > > could one of you try to fix the warning that I get with every > > single build: "/git/arm-soc/arch/arm/kernel/head-nommu.S: Assembler > > messages: /git/arm-soc/arch/arm/kernel/head-nommu.S:167: Warning: > > Use of r13 as a source register is deprecated when r15 is the > > destination register."] > > Moving r13 to r12 and returning r12 seems to do the job (see below). > But I don't know if there is a more elegant way, and if it is also > valid for other architectures than armv7-m. > I can propose a patch if someone can confirm it is valid. Please follow the ARM code example, rather than inventing alternative solutions to the same problem that was solved there. We use r3 for this there: mov r3, r13 ret r3 Consistency _is_ important. Thanks. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/