Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757438AbbEVTJK (ORCPT ); Fri, 22 May 2015 15:09:10 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:49856 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756229AbbEVTJH (ORCPT ); Fri, 22 May 2015 15:09:07 -0400 Date: Fri, 22 May 2015 15:09:03 -0400 (EDT) Message-Id: <20150522.150903.570785706419447424.davem@davemloft.net> To: cascardo@redhat.com Cc: stephen@networkplumber.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, yoshfuji@linux-ipv6.org, Rik.Theys@esat.kuleuven.be Subject: Re: [PATCH] bridge: fix parsing of MLDv2 reports From: David Miller In-Reply-To: <1432307939-19640-1-git-send-email-cascardo@redhat.com> References: <1432307939-19640-1-git-send-email-cascardo@redhat.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 22 May 2015 12:09:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 27 From: Thadeu Lima de Souza Cascardo Date: Fri, 22 May 2015 12:18:59 -0300 > When more than a multicast address is present in a MLDv2 report, all but > the first address is ignored, because the code breaks out of the loop if > there has not been an error adding that address. > > This has caused failures when two guests connected through the bridge > tried to communicate using IPv6. Neighbor discoveries would not be > transmitted to the other guest when both used a link-local address and a > static address. > > This only happens when there is a MLDv2 querier in the network. > > The fix will only break out of the loop when there is a failure adding a > multicast address. ... > Reported-by: Rik Theys > Signed-off-by: Thadeu Lima de Souza Cascardo > Tested-by: Rik Theys Applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/