Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946396AbbEVVXJ (ORCPT ); Fri, 22 May 2015 17:23:09 -0400 Received: from mailrelay117.isp.belgacom.be ([195.238.20.144]:53687 "EHLO mailrelay117.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946153AbbEVVXG (ORCPT ); Fri, 22 May 2015 17:23:06 -0400 X-Belgacom-Dynamic: yes X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=i+EX5EtM4g4P/CrLY+sx2nOWHsqv9AlVwqc0uudqMuE= c=1 sm=2 a=7F6EQ5JhkoQFAlClqCwA:9 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2APVQDRnV9V/yN5sltcgXKBHoEysRQLBQGBBJhSgTo9EAEBAQEBAQGBCkEFhDkjgRo3iDAB1GKGFolEZR2EFwWeDo0VihEjYWYBC4InPDGBA4FEAQEB From: Fabian Frederick To: linux-kernel@vger.kernel.org Cc: Andrew Morton , Alexander Viro , Fabian Frederick , Bob Copeland , linux-karma-devel@lists.sourceforge.net Subject: [RFC 1/1] fs/omfs/file.c: use mpage_readpage() instead of block_read_full_page() Date: Fri, 22 May 2015 23:22:56 +0200 Message-Id: <1432329777-14045-1-git-send-email-fabf@skynet.be> X-Mailer: git-send-email 2.4.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1060 Lines: 36 OMFS uses mpage_readpages() for .readpages which proves it's based on pagecache. Use mpage_readpage() instead of slower bh based block_read_full_page() for .readpage. Is there some test I could link to the patch changelog ? (.readpage seems mainly used in mm/filemap) Regards, Fabian Signed-off-by: Fabian Frederick --- fs/omfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/omfs/file.c b/fs/omfs/file.c index d9e26cf..672d3c2 100644 --- a/fs/omfs/file.c +++ b/fs/omfs/file.c @@ -286,7 +286,7 @@ out: static int omfs_readpage(struct file *file, struct page *page) { - return block_read_full_page(page, omfs_get_block); + return mpage_readpage(page, omfs_get_block); } static int omfs_readpages(struct file *file, struct address_space *mapping, -- 2.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/