Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030263AbbEVVjy (ORCPT ); Fri, 22 May 2015 17:39:54 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:32845 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030243AbbEVVjw (ORCPT ); Fri, 22 May 2015 17:39:52 -0400 MIME-Version: 1.0 In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B40295A91FF1A@G9W0745.americas.hpqcorp.net> References: <20150520205536.32249.89779.stgit@dwillia2-desk3.amr.corp.intel.com> <20150520205749.32249.9040.stgit@dwillia2-desk3.amr.corp.intel.com> <94D0CD8314A33A4D9D801C0FE68B40295A91FF1A@G9W0745.americas.hpqcorp.net> Date: Fri, 22 May 2015 14:39:51 -0700 Message-ID: Subject: Re: [PATCH v3 18/21] nd_btt: atomic sector updates From: Dan Williams To: "Elliott, Robert (Server Storage)" Cc: "axboe@kernel.dk" , "mingo@kernel.org" , "linux-nvdimm@lists.01.org" , "neilb@suse.de" , "gregkh@linuxfoundation.org" , Dave Chinner , "linux-kernel@vger.kernel.org" , Andy Lutomirski , Jens Axboe , "linux-acpi@vger.kernel.org" , "H. Peter Anvin" , "hch@lst.de" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2225 Lines: 56 On Fri, May 22, 2015 at 2:16 PM, Elliott, Robert (Server Storage) wrote: > > >> -----Original Message----- >> From: Linux-nvdimm [mailto:linux-nvdimm-bounces@lists.01.org] On Behalf Of >> Dan Williams >> Sent: Wednesday, May 20, 2015 3:58 PM >> To: axboe@kernel.dk >> Cc: mingo@kernel.org; linux-nvdimm@lists.01.org; neilb@suse.de; >> gregkh@linuxfoundation.org; Dave Chinner; linux-kernel@vger.kernel.org; Andy >> Lutomirski; Jens Axboe; linux-acpi@vger.kernel.org; H. Peter Anvin; >> hch@lst.de >> Subject: [PATCH v3 18/21] nd_btt: atomic sector updates >> >> From: Vishal Verma >> > ... >> diff --git a/drivers/block/nd/Kconfig b/drivers/block/nd/Kconfig >> index 00d9afe9475e..2b169806eac5 100644 >> --- a/drivers/block/nd/Kconfig >> +++ b/drivers/block/nd/Kconfig >> @@ -32,9 +32,25 @@ config BLK_DEV_PMEM >> capable of DAX (direct-access) file system mappings. See >> Documentation/blockdev/nd.txt for more details. >> >> - Say Y if you want to use a NVDIMM described by NFIT >> + Say Y if you want to use a NVDIMM described by ACPI, E820, etc... >> >> config ND_BTT_DEVS >> - def_bool y >> + bool >> + >> +config ND_BTT >> + tristate "BTT: Block Translation Table (atomic sector updates)" >> + depends on LIBND >> + default LIBND >> + select ND_BTT_DEVS > > The ND_BTT option, which is presented during a kernel build, > is missing help text. So is E820_PMEM in patch 3/21. > Right, but another alternative is hiding the ability to configure it altogether. Perhaps just build them in always. I made them configurable for those kernel size folks that like the ability to throw away things they don't need, but this may be a degree of freedom too far. E820_PMEM is a bit more straightforward, and could use a help comment like "you've already gone through the trouble to turn on X86_PMEM_LEGACY, you had better turn on the driver too, otherwise what's the point" :). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/