Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161090AbbEVVqU (ORCPT ); Fri, 22 May 2015 17:46:20 -0400 Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161013AbbEVVqS (ORCPT ); Fri, 22 May 2015 17:46:18 -0400 Message-ID: <555FA3A5.7070600@nod.at> Date: Fri, 22 May 2015 23:46:13 +0200 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Fabian Frederick CC: "linux-mtd@lists.infradead.org" , Artem Bityutskiy , LKML , Adrian Hunter Subject: Re: [PATCH 6/6 linux-next] ubifs: remove else after return References: <1431726240-4675-1-git-send-email-fabf@skynet.be> <1431726240-4675-6-git-send-email-fabf@skynet.be> <1796356142.534811.1432057342188.open-xchange@webmail.nmp.proximus.be> <555B797B.90309@nod.at> <357577728.30474.1432330663780.open-xchange@webmail.nmp.proximus.be> In-Reply-To: <357577728.30474.1432330663780.open-xchange@webmail.nmp.proximus.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 31 Am 22.05.2015 um 23:37 schrieb Fabian Frederick: > > >> On 19 May 2015 at 19:57 Richard Weinberger wrote: >> >> >> Am 19.05.2015 um 19:42 schrieb Fabian Frederick: >>> All was compiled but untested. >> >> Can you please test your changes too? >> Trivial looking changes introduce sometimes issues and having them >> tested would be wonderful. >> >> You can test UBIFS using nandsim or mtdram on any Linux >> system. >> See: http://www.linux-mtd.infradead.org/faq/nand.html#L_nand_nandsim > > I guess the following patches can be applied without testing ? Let me put it to you this way, refusing to test your patches does not increase the possibility to get them merged. :-) Really, test your patches and don't become a patch bot. Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/