Message-ID: <555FAC8F.4010306@amd.com>
Date: Fri, 22 May 2015 17:24:15 -0500
From: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
CC: <lenb@kernel.org>, <catalin.marinas@arm.com>, <will.deacon@arm.com>,
        <thomas.lendacky@amd.com>, <herbert@gondor.apana.org.au>,
        <davem@davemloft.net>, <arnd@arndb.de>, <msalter@redhat.com>,
        <hanjun.guo@linaro.org>, <al.stone@linaro.org>,
        <grant.likely@linaro.org>, <leo.duran@amd.com>,
        <linux-arm-kernel@lists.infradead.org>, <linux-acpi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linaro-acpi@lists.linaro.org>,
        <netdev@vger.kernel.org>, <linux-crypto@vger.kernel.org>
Subject: Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency
References: <1432159758-4486-1-git-send-email-Suravee.Suthikulpanit@amd.com>
 <1432159758-4486-2-git-send-email-Suravee.Suthikulpanit@amd.com>
 <1815824.lIg0NQ97lU@vostro.rjw.lan>
In-Reply-To: <1815824.lIg0NQ97lU@vostro.rjw.lan>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2015 22:24:53.4735
 (UTC)
X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221];Helo=[atltwp01.amd.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB073
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1522
Lines: 46

Not sure if this went out earlier. So I am resending.

On 5/22/15 16:56, Rafael J. Wysocki wrote:
>> diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c
>> >index 39c485b..b9657af 100644
>> >--- a/drivers/acpi/glue.c
>> >+++ b/drivers/acpi/glue.c
>> >@@ -13,6 +13,7 @@
>> >  #include <linux/slab.h>
>> >  #include <linux/rwsem.h>
>> >  #include <linux/acpi.h>
>> >+#include <linux/dma-mapping.h>
>> >
>> >  #include "internal.h"
>> >
>> >@@ -167,6 +168,7 @@ int acpi_bind_one(struct device *dev, struct acpi_device *acpi_dev)
>> >  	struct list_head *physnode_list;
>> >  	unsigned int node_id;
>> >  	int retval = -EINVAL;
>> >+	bool coherent;
>> >
>> >  	if (has_acpi_companion(dev)) {
>> >  		if (acpi_dev) {
>> >@@ -223,6 +225,9 @@ int acpi_bind_one(struct device *dev, struct acpi_device *acpi_dev)
>> >  	if (!has_acpi_companion(dev))
>> >  		ACPI_COMPANION_SET(dev, acpi_dev);
>> >
>> >+	if (acpi_check_dma(acpi_dev, &coherent))
>> >+		arch_setup_dma_ops(dev, 0, 0, NULL, coherent);
>> >+
> Well, so is this going to work for PCI too after all?
>

No, as Bjorn suggested, PCI changes for setting DMA coherent from _CCA 
(patch 3/6 in V4) will be submitted separately. We are working on 
cleaning up and up-streaming the PCI ACPI support for ARM64.

Thanks,

Suravee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/