Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161143AbbEVWqB (ORCPT ); Fri, 22 May 2015 18:46:01 -0400 Received: from mail-lb0-f178.google.com ([209.85.217.178]:34389 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946049AbbEVWp7 convert rfc822-to-8bit (ORCPT ); Fri, 22 May 2015 18:45:59 -0400 MIME-Version: 1.0 In-Reply-To: <1431600868-11737-3-git-send-email-pali.rohar@gmail.com> References: <1416755361-17357-1-git-send-email-pali.rohar@gmail.com> <1431600868-11737-1-git-send-email-pali.rohar@gmail.com> <1431600868-11737-3-git-send-email-pali.rohar@gmail.com> Date: Fri, 22 May 2015 15:45:57 -0700 Message-ID: Subject: Re: [PATCH v3 2/3] dell-rbtn: Export notifier for other kernel modules From: Dmitry Torokhov To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Darren Hart , platform-driver-x86@vger.kernel.org, lkml , Gabriele Mazzotta , Alex Hung , Matthew Garrett , Darren Hart Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 841 Lines: 24 On Thu, May 14, 2015 at 3:54 AM, Pali Rohár wrote: > @@ -328,7 +408,9 @@ static void rbtn_notify(struct acpi_device *device, u32 event) > > static int __init rbtn_init(void) > { > - return acpi_bus_register_driver(&rbtn_driver); > + /* ignore errors so module always loads and exports needed functions */ > + acpi_bus_register_driver(&rbtn_driver); > + return 0; Ahem, and if it fails for some reason and you try to unload the module what will happen when you call acpi_bus_unregister_driver(&rbtn_driver) in rbtn_exit()?\ Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/