Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757269AbbEVW6N (ORCPT ); Fri, 22 May 2015 18:58:13 -0400 Received: from www.linutronix.de ([62.245.132.108]:45503 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756983AbbEVW6M (ORCPT ); Fri, 22 May 2015 18:58:12 -0400 Date: Sat, 23 May 2015 00:58:18 +0200 (CEST) From: Thomas Gleixner To: Ingo Molnar cc: John Stultz , LKML , Badhri Jagan Sridharan Subject: Re: [PATCH 4/7] tracing: timer: Add deferrable flag to timer_start In-Reply-To: <20150521061837.GB11077@gmail.com> Message-ID: References: <1432142376-2077-1-git-send-email-john.stultz@linaro.org> <1432142376-2077-5-git-send-email-john.stultz@linaro.org> <20150521061837.GB11077@gmail.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 991 Lines: 26 On Thu, 21 May 2015, Ingo Molnar wrote: > * John Stultz wrote: > > - TP_PROTO(struct timer_list *timer, unsigned long expires), > > + TP_PROTO(struct timer_list *timer, > > + unsigned long expires, > > This isn't compat safe, should any tooling rely on this. I can't see how that matters. The binary trace tells you from which machine (32 or 64 bit) it comes. So the field size is available for the tool. If the tool blindly applies the format string, it's hardly a fault of the kernel. And there is no point to bloat 32bit tracing with 64bit entries just because some random tool might be stupid. Just for the record: We have 539 'unsigned long' and 62 'long' event fields in include/trace/events/. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/