Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757831AbbEVXC5 (ORCPT ); Fri, 22 May 2015 19:02:57 -0400 Received: from mail-ie0-f169.google.com ([209.85.223.169]:34278 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757746AbbEVXCy (ORCPT ); Fri, 22 May 2015 19:02:54 -0400 MIME-Version: 1.0 In-Reply-To: <20150522223349.GA11950@gondor.apana.org.au> References: <1432282668.27695.24.camel@x220> <20150522175711.GE40101@dtor-ws> <20150522181924.GN23057@wotan.suse.de> <20150522185207.GG40101@dtor-ws> <20150522192814.GO23057@wotan.suse.de> <20150522214357.GA24129@cloud> <20150522222200.GP23057@wotan.suse.de> <20150522223349.GA11950@gondor.apana.org.au> From: "Luis R. Rodriguez" Date: Fri, 22 May 2015 16:02:33 -0700 X-Google-Sender-Auth: qPxQdSkViw-0UoV7a8deBCbJQ0c Message-ID: Subject: Re: [RFC v1] tree-wide: remove "select FW_LOADER" uses To: Herbert Xu Cc: josh@joshtriplett.org, Dmitry Torokhov , Takashi Iwai , Paul Bolle , Geert Uytterhoeven , Borislav Petkov , Greg KH , "David S. Miller" , clemens@ladisch.de, JBottomley@odin.com, David Airlie , Mauro Carvalho Chehab , Marcel Holtmann , "Gustavo F. Padovan" , Johan Hedberg , Mikael Starvik , Jesper Nilsson , Imre Kaloz , khalasa@piap.pl, Ohad Ben-Cohen , Arnd Bergmann , 3chas3@gmail.com, Jiri Slaby , Bryan Wu , Richard Purdie , Jacek Anaszewski , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1113 Lines: 25 On Fri, May 22, 2015 at 3:33 PM, Herbert Xu wrote: > On Sat, May 23, 2015 at 12:22:00AM +0200, Luis R. Rodriguez wrote: >> Kind of, the issue actually was a new component which depends on FW_LOADER >> and has crypto dependencies. Since the qat crypto driver selects FW_LOADER >> but also has a set of crypto dependencies that creates a recursive dependency >> loop. > > Actually, how about making FW_SIG select FW_LOADER instead of > depending on it? I think this should break the cycle. Indeed, it does. Kind of odd, but works - and well if others run into the recursive issue then we have two diverging solutions now: a) Either swap all "select FOO" to "depends on FOO" or, b) Change the offending "depends on FOO" to "select FOO" So sticking to one seems to make Kconfig happy for recursive dependency solving for now... Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/