Date: Fri, 22 May 2015 16:54:45 -0700
From: Josh Triplett <josh@joshtriplett.org>
To: "Luis R. Rodriguez" <mcgrof@suse.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Takashi Iwai <tiwai@suse.de>, Paul Bolle <pebolle@tiscali.nl>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Borislav Petkov <bp@alien8.de>, Greg KH <gregkh@linuxfoundation.org>,
        "David S. Miller" <davem@davemloft.net>, clemens@ladisch.de,
        JBottomley@odin.com, David Airlie <airlied@linux.ie>,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
        Marcel Holtmann <marcel@holtmann.org>,
        "Gustavo F. Padovan" <gustavo@padovan.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Mikael Starvik <starvik@axis.com>,
        Jesper Nilsson <jesper.nilsson@axis.com>,
        Imre Kaloz <kaloz@openwrt.org>, khalasa@piap.pl,
        Ohad Ben-Cohen <ohad@wizery.com>, Arnd Bergmann <arnd@arndb.de>,
        3chas3@gmail.com, Jiri Slaby <jslaby@suse.cz>,
        Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
        Jacek Anaszewski <j.anaszewski@samsung.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC v1] tree-wide: remove "select FW_LOADER" uses
Message-ID: <20150522235445.GA21938@jtriplet-mobl1>
References: <s5h7fs1gfxl.wl-tiwai@suse.de>
 <CAB=NE6WLsOoWOBwcHW5FC4k4GEtW-JWap52Zs34H-JZNtFxrhA@mail.gmail.com>
 <20150522175711.GE40101@dtor-ws>
 <20150522181924.GN23057@wotan.suse.de>
 <20150522185207.GG40101@dtor-ws>
 <20150522192814.GO23057@wotan.suse.de>
 <20150522214357.GA24129@cloud>
 <20150522222200.GP23057@wotan.suse.de>
 <20150522223349.GA11950@gondor.apana.org.au>
 <CAB=NE6WDknSfw5Y6tLCrEnvW=PnNi8sWnVKumUaEYx86xTOQBA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAB=NE6WDknSfw5Y6tLCrEnvW=PnNi8sWnVKumUaEYx86xTOQBA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1600
Lines: 34

On Fri, May 22, 2015 at 04:02:33PM -0700, Luis R. Rodriguez wrote:
> On Fri, May 22, 2015 at 3:33 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> > On Sat, May 23, 2015 at 12:22:00AM +0200, Luis R. Rodriguez wrote:
> >> Kind of, the issue actually was a new component which depends on FW_LOADER
> >> and has crypto dependencies. Since the qat crypto driver selects FW_LOADER
> >> but also has a set of crypto dependencies that creates a recursive dependency
> >> loop.
> >
> > Actually, how about making FW_SIG select FW_LOADER instead of
> > depending on it? I think this should break the cycle.
> 
> Indeed, it does. Kind of odd, but works - and well if others run into
> the recursive issue then we have two diverging solutions now:
> 
>   a) Either swap all "select FOO" to "depends on FOO" or,
>   b) Change the offending "depends on FOO" to "select FOO"
> 
> So sticking to one seems to make Kconfig happy for recursive
> dependency solving for now...

For simplicity and avoidance of massive tree-wide patches, (b) seems
preferable in this case.

Long-term, I think ideally we should have *every* visible Kconfig option
always pulled in by "depends on" rather than "select", with visibility
and recursion handled by smarter tools.  That said, meddle not in the
internals of Kconfig, for it has many unshorn yaks (and yaccs).

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/