Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757766AbbEWADN (ORCPT ); Fri, 22 May 2015 20:03:13 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:35245 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757583AbbEWADI (ORCPT ); Fri, 22 May 2015 20:03:08 -0400 Message-ID: <555FC3AC.1090108@linaro.org> Date: Sat, 23 May 2015 08:02:52 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "Zheng, Lv" , "Wysocki, Rafael J" , "Brown, Len" CC: Lv Zheng , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "Moore, Robert" Subject: Re: [PATCH 12/19] ACPICA: ACPI 6.0: Add changes for MADT table. References: <555DED69.7040203@linaro.org> <1AE640813FDE7649BE1B193DEA596E8802720DDD@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <1AE640813FDE7649BE1B193DEA596E8802720DDD@SHSMSX101.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2306 Lines: 69 On 2015年05月22日 08:16, Zheng, Lv wrote: > Hi, > >> From: Hanjun Guo [mailto:hanjun.guo@linaro.org] >> Sent: Thursday, May 21, 2015 10:36 PM >> >> Hi Lv, >> >> On 2015年05月21日 10:31, Lv Zheng wrote: >>> From: Bob Moore >>> >>> ACPICA commit 02cbb41232bccf7a91967140cab95d5f48291f21 >>> >>> New subtable type. Some additions to existing subtables. >>> >>> Link: https://github.com/acpica/acpica/commit/02cbb412 >>> Signed-off-by: Bob Moore >>> Signed-off-by: Lv Zheng >>> --- >> [...] >>> >>> /* Masks for Flags field above */ >>> @@ -819,7 +822,7 @@ struct acpi_madt_generic_interrupt { >>> #define ACPI_MADT_PERFORMANCE_IRQ_MODE (1<<1) /* 01: Performance Interrupt Mode */ >>> #define ACPI_MADT_VGIC_IRQ_MODE (1<<2) /* 02: VGIC Maintenance Interrupt mode */ >>> >>> -/* 12: Generic Distributor (ACPI 5.0) */ >>> +/* 12: Generic Distributor (ACPI 5.0 + ACPI 6.0 changes) */ >>> >>> struct acpi_madt_generic_distributor { >>> struct acpi_subtable_header header; >>> @@ -827,7 +830,8 @@ struct acpi_madt_generic_distributor { >>> u32 gic_id; >>> u64 base_address; >>> u32 global_irq_base; >>> - u32 reserved2; /* reserved - must be zero */ >>> + u8 version; >> >> version filed in generic distributor has following values, >> >> /* Values for gic_version in Generic Distributor (ACPI 6.0) */ >> >> enum acpi_madt_gic_ver_type >> { >> ACPI_MADT_GIC_VER_UNKNOWN = 0, >> ACPI_MADT_GIC_VER_V1 = 1, >> ACPI_MADT_GIC_VER_V2 = 2, >> ACPI_MADT_GIC_VER_V3 = 3, >> ACPI_MADT_GIC_VER_V4 = 4, >> ACPI_MADT_GIC_VER_RESERVED = 5 /* 5 and greater are >> reserved */ >> }; >> >> should we put it here, or locate it to ARM64 arch related head >> file? > > Yes, you can put it here. > And also please help to submit an ACPICA patch to . OK, I think it is a fix to this patch too, I will prepare a patch soon. Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/