Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757573AbbEWAZd (ORCPT ); Fri, 22 May 2015 20:25:33 -0400 Received: from mga09.intel.com ([134.134.136.24]:26431 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757213AbbEWAZb convert rfc822-to-8bit (ORCPT ); Fri, 22 May 2015 20:25:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,479,1427785200"; d="scan'208";a="699138830" From: "Drokin, Oleg" To: Joe Perches CC: Julia Lawall , Michael Shuey , "" , "" , "" , "" , "" , "" Subject: Re: [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes Thread-Topic: [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes Thread-Index: AQHQlOsE9huCFEcf6U2xtGRkHfz1+Z2JJHwAgAAC5oCAAAISgA== Date: Sat, 23 May 2015 00:25:29 +0000 Message-ID: <467D21EA-E5E8-4F16-AABD-31D79062FFF9@intel.com> References: <1432237849-53947-1-git-send-email-shuey@purdue.edu> <1432237849-53947-11-git-send-email-shuey@purdue.edu> <1432242004.20840.68.camel@perches.com> <15C0AFDB-CA69-40E5-B65E-C559A5B5CE47@intel.com> <1432309337.29657.16.camel@perches.com> <05DE4AF3-20A6-40F6-BAC6-79C140E490AF@intel.com> <1432339030.29657.20.camel@perches.com> <863F0D66-99B1-4658-8A99-E3A843E0E8FC@intel.com> <1432340285.29657.26.camel@perches.com> In-Reply-To: <1432340285.29657.26.camel@perches.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.20.199] Content-Type: text/plain; charset=US-ASCII Content-ID: <2E1287ED2CFD9F40855F2361E41FBD89@intel.com> Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1024 Lines: 24 On May 22, 2015, at 8:18 PM, Joe Perches wrote: >>>> I wonder what is more clear about that in your opinion ve >>>> lustre_error/lustre_debug? >>> >>> The fact that you have to explain this shows that it's >>> at least misleading unless you completely understand the >>> code. >> >> Or you know, you might take the function name at the face value >> and assume that CERROR means it's an error and CDEBUG means it's a debug message? > > Maybe, but I think that it'd be better if the mechanism > it uses was more plainly named something like lustre_log. While the idea seems good, the biggest obstacle here is such that there's already a thing called lustre log (llog for short too) - it's kind of a distributed journal of operations. Its there a different synonym, I wonder?-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/