Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757910AbbEWBFz (ORCPT ); Fri, 22 May 2015 21:05:55 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:37728 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757887AbbEWBFx (ORCPT ); Fri, 22 May 2015 21:05:53 -0400 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Dmitry Torokhov Subject: Re: [PATCH v3 2/3] dell-rbtn: Export notifier for other kernel modules Date: Sat, 23 May 2015 03:05:50 +0200 User-Agent: KMail/1.13.7 (Linux/3.13.0-53-generic; KDE/4.14.2; x86_64; ; ) Cc: Darren Hart , platform-driver-x86@vger.kernel.org, lkml , Gabriele Mazzotta , Alex Hung , Matthew Garrett , Darren Hart References: <1416755361-17357-1-git-send-email-pali.rohar@gmail.com> <1431600868-11737-3-git-send-email-pali.rohar@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6494080.Jv0g0R2ps8"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201505230305.50655@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1641 Lines: 51 --nextPart6494080.Jv0g0R2ps8 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Saturday 23 May 2015 00:45:57 Dmitry Torokhov wrote: > On Thu, May 14, 2015 at 3:54 AM, Pali Roh=C3=A1r > wrote: > > @@ -328,7 +408,9 @@ static void rbtn_notify(struct acpi_device > > *device, u32 event) > >=20 > > static int __init rbtn_init(void) > > { > >=20 > > - return acpi_bus_register_driver(&rbtn_driver); > > + /* ignore errors so module always loads and exports needed > > functions */ + acpi_bus_register_driver(&rbtn_driver); > > + return 0; >=20 > Ahem, and if it fails for some reason and you try to unload the > module what will happen when you call > acpi_bus_unregister_driver(&rbtn_driver) in rbtn_exit()?\ >=20 > Thanks. I'm thinking about using symbol_request() in dell-laptop.c (instead hard=20 dependency) and then not ignoring error here... It could fix this=20 problem. =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart6494080.Jv0g0R2ps8 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlVf0m4ACgkQi/DJPQPkQ1LgoQCeKJCJEQk1LDuevI/N/ceXUrrS QW8AoJOtCDqvtUGPLunAZZ93L4ajv3df =BC2h -----END PGP SIGNATURE----- --nextPart6494080.Jv0g0R2ps8-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/