Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757240AbbEWDaX (ORCPT ); Fri, 22 May 2015 23:30:23 -0400 Received: from [68.232.143.164] ([68.232.143.164]:63262 "EHLO esa2.cray.iphmx.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1756243AbbEWDaV convert rfc822-to-8bit (ORCPT ); Fri, 22 May 2015 23:30:21 -0400 X-Greylist: delayed 919 seconds by postgrey-1.27 at vger.kernel.org; Fri, 22 May 2015 23:30:21 EDT X-IronPort-AV: E=Sophos;i="5.13,480,1427756400"; d="scan'208";a="2259646" From: Patrick Farrell To: Joe Perches , "Drokin, Oleg" CC: "" , "" , "" , "" , Julia Lawall , "" , "" Subject: RE: [HPDD-discuss] [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes Thread-Topic: [HPDD-discuss] [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes Thread-Index: AQHQlO8NNdA91tg6rE6lIENnfeRD9p2JCvkA///XvuM= Date: Sat, 23 May 2015 03:13:42 +0000 Message-ID: References: <1432237849-53947-1-git-send-email-shuey@purdue.edu> <1432237849-53947-11-git-send-email-shuey@purdue.edu> <1432242004.20840.68.camel@perches.com> <15C0AFDB-CA69-40E5-B65E-C559A5B5CE47@intel.com> <1432309337.29657.16.camel@perches.com> <05DE4AF3-20A6-40F6-BAC6-79C140E490AF@intel.com> <1432339030.29657.20.camel@perches.com> <863F0D66-99B1-4658-8A99-E3A843E0E8FC@intel.com> <1432340285.29657.26.camel@perches.com> <467D21EA-E5E8-4F16-AABD-31D79062FFF9@intel.com>,<1432341390.29657.29.camel@perches.com> In-Reply-To: <1432341390.29657.29.camel@perches.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.233.68] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1944 Lines: 44 Since it is not actually doing a printk - at least, not necessarily - I like lustre_logmsg. lustre_output seems too vague. - Patrick ________________________________________ From: HPDD-discuss [hpdd-discuss-bounces@lists.01.org] on behalf of Joe Perches [joe@perches.com] Sent: Friday, May 22, 2015 7:36 PM To: Drokin, Oleg Cc: ; ; ; ; Julia Lawall; ; Subject: Re: [HPDD-discuss] [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes On Sat, 2015-05-23 at 00:25 +0000, Drokin, Oleg wrote: > On May 22, 2015, at 8:18 PM, Joe Perches wrote: > >>>> I wonder what is more clear about that in your opinion ve > >>>> lustre_error/lustre_debug? > >>> > >>> The fact that you have to explain this shows that it's > >>> at least misleading unless you completely understand the > >>> code. > >> > >> Or you know, you might take the function name at the face value > >> and assume that CERROR means it's an error and CDEBUG means it's a debug message? > > > > Maybe, but I think that it'd be better if the mechanism > > it uses was more plainly named something like lustre_log. > > While the idea seems good, the biggest obstacle here is such that > there's already a thing called lustre log (llog for short too) - > it's kind of a distributed journal of operations. > > Its there a different synonym, I wonder? Maybe: lustre_printk, lustre_logmsg, lustre_output _______________________________________________ HPDD-discuss mailing list HPDD-discuss@lists.01.org https://lists.01.org/mailman/listinfo/hpdd-discuss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/