Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757389AbbEWHOf (ORCPT ); Sat, 23 May 2015 03:14:35 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:34464 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755039AbbEWHOe (ORCPT ); Sat, 23 May 2015 03:14:34 -0400 MIME-Version: 1.0 In-Reply-To: References: <1432282668.27695.24.camel@x220> <20150522175711.GE40101@dtor-ws> <20150522181924.GN23057@wotan.suse.de> <20150522185207.GG40101@dtor-ws> <20150522192814.GO23057@wotan.suse.de> <20150522214357.GA24129@cloud> <20150522222200.GP23057@wotan.suse.de> <20150522223349.GA11950@gondor.apana.org.au> Date: Sat, 23 May 2015 09:14:33 +0200 X-Google-Sender-Auth: cFN63KVISUp9v0Hi8KmptD_f85c Message-ID: Subject: Re: [RFC v1] tree-wide: remove "select FW_LOADER" uses From: Geert Uytterhoeven To: "Luis R. Rodriguez" Cc: Herbert Xu , Josh Triplett , Dmitry Torokhov , Takashi Iwai , Paul Bolle , Borislav Petkov , Greg KH , "David S. Miller" , clemens@ladisch.de, JBottomley@odin.com, David Airlie , Mauro Carvalho Chehab , Marcel Holtmann , "Gustavo F. Padovan" , Johan Hedberg , Mikael Starvik , Jesper Nilsson , Imre Kaloz , khalasa@piap.pl, Ohad Ben-Cohen , Arnd Bergmann , 3chas3@gmail.com, Jiri Slaby , Bryan Wu , Richard Purdie , Jacek Anaszewski , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1785 Lines: 42 On Sat, May 23, 2015 at 1:02 AM, Luis R. Rodriguez wrote: > On Fri, May 22, 2015 at 3:33 PM, Herbert Xu wrote: >> On Sat, May 23, 2015 at 12:22:00AM +0200, Luis R. Rodriguez wrote: >>> Kind of, the issue actually was a new component which depends on FW_LOADER >>> and has crypto dependencies. Since the qat crypto driver selects FW_LOADER >>> but also has a set of crypto dependencies that creates a recursive dependency >>> loop. >> >> Actually, how about making FW_SIG select FW_LOADER instead of >> depending on it? I think this should break the cycle. > > Indeed, it does. Kind of odd, but works - and well if others run into > the recursive issue then we have two diverging solutions now: > > a) Either swap all "select FOO" to "depends on FOO" or, > b) Change the offending "depends on FOO" to "select FOO" > > So sticking to one seems to make Kconfig happy for recursive > dependency solving for now... Yes, that works, too. Perhaps Kconfig should start warning if it encounters a symbol that is both selected and being depended on, even without detecting an explicit recursive dependency? That's gonna give tons of warnings, though... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/