Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758101AbbEWR1B (ORCPT <rfc822;w@1wt.eu>);
	Sat, 23 May 2015 13:27:01 -0400
Received: from smtprelay0077.hostedemail.com ([216.40.44.77]:41430 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1757957AbbEWR04 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 23 May 2015 13:26:56 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2734:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3871:3872:4321:5007:6261:7903:10004:10400:10848:11232:11658:11914:12219:12296:12517:12519:12663:12740:13019:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: vase21_1f592989d161
X-Filterd-Recvd-Size: 2418
Message-ID: <1432402012.29657.52.camel@perches.com>
Subject: Re: [PATCH] checkpatch: Categorize some long line length checks
From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Andrew Morton <akpm@linux-foundation.org>, oleg.drokin@intel.com,
        devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
        HPDD-discuss@ml01.01.org, lustre-deve@lists.lustre.org,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Mike Shuey <shuey@purdue.edu>
Date: Sat, 23 May 2015 10:26:52 -0700
In-Reply-To: <alpine.DEB.2.10.1505231331050.2554@hadrien>
References: <1432237849-53947-1-git-send-email-shuey@purdue.edu>
	 <1432237849-53947-11-git-send-email-shuey@purdue.edu>
	 <1432242004.20840.68.camel@perches.com>
	 <1432362494.29657.40.camel@perches.com>
	 <alpine.DEB.2.10.1505231331050.2554@hadrien>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.11-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1371
Lines: 43

On Sat, 2015-05-23 at 13:32 +0200, Julia Lawall wrote:
> On Fri, 22 May 2015, Joe Perches wrote:
> > Many lines of code extend beyond the maximum line length.
> > Some of these are possibly justified by use type.
> >
> > For instance:
> >
> > structure definitions where comments are added per member like
> >
> > struct foo {
> > 	type member;		/* some long description */
> 
> I'm not super fond of the comment one.  Perhaps people could express
> themselves more concisely, or put the details elsewhere?

Concision is good, straining for brevity or bad
formatting isn't.

I've seen a lot of ugly patches lately to "fix"
code like this by making it worse.

By default, there is still a long_line warning for
this style.  It arguably could be appropriate to
keep some lines like this and this makes it easy
to tell people "add --ignore=<type>".

This patch shouldn't be applied right now anyway.

I think the idea is OK, but this implementation
could be improved and clarified by moving the
current exclusions before the classifications.

Anyone else have an opinion?

I'll send a V2 later unless there are more comments.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/