Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751665AbbEYBHS (ORCPT ); Sun, 24 May 2015 21:07:18 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:33234 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751366AbbEYBHQ (ORCPT ); Sun, 24 May 2015 21:07:16 -0400 Date: Mon, 25 May 2015 10:06:42 +0900 (JST) Message-Id: <20150525.100642.1998714117047339503.konishi.ryusuke@lab.ntt.co.jp> To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Alexander Viro , linux-nilfs@vger.kernel.org, Christoph Hellwig , Boaz Harrosh , Benny Halevy , osd-dev@open-osd.org, Jan Kara , linux-ext4@vger.kernel.org, Evgeniy Dushistov Subject: Re: [PATCH 2/9 linux-next] nilfs2: remove dir_pages() declaration From: Ryusuke Konishi In-Reply-To: <1432480791-31396-3-git-send-email-fabf@skynet.be> References: <1432480791-31396-1-git-send-email-fabf@skynet.be> <1432480791-31396-3-git-send-email-fabf@skynet.be> X-Mailer: Mew version 6.6 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1619 Lines: 50 On Sun, 24 May 2015 17:19:42 +0200, Fabian Frederick wrote: > dir_pages() is now declared in pagemap.h > > Signed-off-by: Fabian Frederick > --- > fs/nilfs2/dir.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/fs/nilfs2/dir.c b/fs/nilfs2/dir.c > index 0ee0bed..6b8b92b 100644 > --- a/fs/nilfs2/dir.c > +++ b/fs/nilfs2/dir.c > @@ -61,11 +61,6 @@ static inline void nilfs_put_page(struct page *page) > page_cache_release(page); > } > > -static inline unsigned long dir_pages(struct inode *inode) > -{ > - return (inode->i_size+PAGE_CACHE_SIZE-1)>>PAGE_CACHE_SHIFT; > -} > - Can you include this and similar changes in the first patch "pagemap.h: declare dir_pages()" ? The first patch transiently breaks build because it inserts a duplicate definition of the dir_pages() inline function until it gets removed from each file system by the successive patches. This series looks non-divisible except the patch of ufs. Regards, Ryusuke Konishi > /* > * Return the offset into page `page_nr' of the last valid > * byte in that page, plus one. > -- > 2.4.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/