Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751445AbbEYFFf (ORCPT ); Mon, 25 May 2015 01:05:35 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60361 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbbEYFFe (ORCPT ); Mon, 25 May 2015 01:05:34 -0400 Message-ID: <5562AD98.4020307@codeaurora.org> Date: Mon, 25 May 2015 10:35:28 +0530 From: Archit Taneja User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Hai Li , dri-devel@lists.freedesktop.org CC: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/msm/mdp5: Always generate active-high sync signals for DSI References: <1432304206-18765-1-git-send-email-hali@codeaurora.org> In-Reply-To: <1432304206-18765-1-git-send-email-hali@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1775 Lines: 47 On 05/22/2015 07:46 PM, Hai Li wrote: > DSI video mode engine can only take active-high sync signals. This > change prevents MDP5 sending active-low sync signals to DSI in any > case. > > Signed-off-by: Hai Li Tested-by: Archit Taneja > --- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c > index 53bb1f7..2e98ce0 100644 > --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c > +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c > @@ -144,10 +144,14 @@ static void mdp5_encoder_mode_set(struct drm_encoder *encoder, > mode->type, mode->flags); > > ctrl_pol = 0; > - if (mode->flags & DRM_MODE_FLAG_NHSYNC) > - ctrl_pol |= MDP5_INTF_POLARITY_CTL_HSYNC_LOW; > - if (mode->flags & DRM_MODE_FLAG_NVSYNC) > - ctrl_pol |= MDP5_INTF_POLARITY_CTL_VSYNC_LOW; > + > + /* DSI controller cannot handle active-low sync signals. */ > + if (mdp5_encoder->intf.type != INTF_DSI) { > + if (mode->flags & DRM_MODE_FLAG_NHSYNC) > + ctrl_pol |= MDP5_INTF_POLARITY_CTL_HSYNC_LOW; > + if (mode->flags & DRM_MODE_FLAG_NVSYNC) > + ctrl_pol |= MDP5_INTF_POLARITY_CTL_VSYNC_LOW; > + } > /* probably need to get DATA_EN polarity from panel.. */ > > dtv_hsync_skew = 0; /* get this from panel? */ > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/