Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751961AbbEYGYF (ORCPT ); Mon, 25 May 2015 02:24:05 -0400 Received: from mga03.intel.com ([134.134.136.65]:29371 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783AbbEYGYD (ORCPT ); Mon, 25 May 2015 02:24:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,489,1427785200"; d="scan'208";a="576334360" Message-ID: <5562C000.8010302@linux.intel.com> Date: Mon, 25 May 2015 14:24:00 +0800 From: "Lu, Baolu" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: David Cohen CC: Heikki Krogerus , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall References: <1432294155-18039-1-git-send-email-baolu.lu@linux.intel.com> <20150522160845.GA31627@psi-dev26.jf.intel.com> In-Reply-To: <20150522160845.GA31627@psi-dev26.jf.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1824 Lines: 63 On 05/23/2015 12:08 AM, David Cohen wrote: > Hi, > > On Fri, May 22, 2015 at 07:29:15PM +0800, Lu Baolu wrote: >> Phy drivers and the ulpi interface providers depend on the >> registeration of the ulpi bus. Ulpi registers the bus in >> module_init(). This could result in a load order issue, i.e. > It's still not an issue :( > I'd say "unnecessary probe delays". I managed to boot a kernel built from the top of Felipe's remotes/origin/next branch under an Ubuntu environment on Intel's Bay Trail tablet. The same panic (as I found in the Android environment previously) shows up as well. And if I replace module_init() with sys_initcall(), the panic disappears. Thanks, -Baolu > > But of cource it's Felipe's call :) Description looks better now. > > BR, David > >> ulpi phy drivers or the ulpi interface providers loading >> before the bus registeration. >> >> This patch fixes this load order issue by putting ulpi_init >> in subsys_initcall(). >> >> Reported-by: Zhuo Qiuxu >> Signed-off-by: Lu Baolu >> --- >> drivers/usb/common/ulpi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c >> index 0e6f968..01c0c04 100644 >> --- a/drivers/usb/common/ulpi.c >> +++ b/drivers/usb/common/ulpi.c >> @@ -242,7 +242,7 @@ static int __init ulpi_init(void) >> { >> return bus_register(&ulpi_bus); >> } >> -module_init(ulpi_init); >> +subsys_initcall(ulpi_init); >> >> static void __exit ulpi_exit(void) >> { >> -- >> 2.1.4 >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/