Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752232AbbEYLRl (ORCPT ); Mon, 25 May 2015 07:17:41 -0400 Received: from down.free-electrons.com ([37.187.137.238]:57798 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751199AbbEYLRk (ORCPT ); Mon, 25 May 2015 07:17:40 -0400 Message-ID: <556304D1.4000907@free-electrons.com> Date: Mon, 25 May 2015 13:17:37 +0200 From: Gregory CLEMENT User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Andrew CC: Sebastian Hesselbarth , Jason Cooper , Andrew Lunn , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 1/1] ARM: mvebu: dts: Add dts file for DLink DNS-327L References: <1432069858-10958-1-git-send-email-andrew@ncrmnt.org> <1432069858-10958-2-git-send-email-andrew@ncrmnt.org> <555C4E48.6020707@gmail.com> <699cee8678f6e671bd1457aa06180ccf@mail.ncrmnt.org> <555C6935.4000405@gmail.com> In-Reply-To: <555C6935.4000405@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4793 Lines: 137 Hi Andrew, On 20/05/2015 13:00, Sebastian Hesselbarth wrote: > On 20.05.2015 12:20, Andrew wrote: >> Sebastian Hesselbarth писал 20.05.2015 12:05: >>> On 19.05.2015 23:10, Andrew Andrianov wrote: >>>> DNS-327L is a 2-bay NAS with the following specs: >>> [...] >>>> Signed-off-by: Andrew Andrianov >>>> --- >>>> arch/arm/boot/dts/Makefile | 1 + >>>> arch/arm/boot/dts/armada-370-dlink-dns327l.dts | 356 >>>> +++++++++++++++++++++++++ >>>> 2 files changed, 357 insertions(+) >>>> create mode 100644 arch/arm/boot/dts/armada-370-dlink-dns327l.dts >>> [...] >>>> diff --git a/arch/arm/boot/dts/armada-370-dlink-dns327l.dts >>>> b/arch/arm/boot/dts/armada-370-dlink-dns327l.dts >>>> new file mode 100644 >>>> index 0000000..0f4555c4 >>>> --- /dev/null >>>> +++ b/arch/arm/boot/dts/armada-370-dlink-dns327l.dts >>>> @@ -0,0 +1,356 @@ >>> [...] >>>> + regulators { >>>> + compatible = "simple-bus"; >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + pinctrl-0 = <&xhci_pwr_pin >>>> + &sata_l_pwr_pin >>>> + &sata_r_pwr_pin>; >>>> + >>>> + pinctrl-names = "default"; >>> >>> I doubt pinctrl will not work as you expected. For regulators, unlike >>> gpio-keys/leds above, this node just describes the "bus" of regulators. >> >> Are you sure about this moment? FYI: I've taken >> armada-370-synology-ds213j.dts >> as the reference which happens to list regulator pinctrl (As of 4.1-rc1) >> just the same way: >> >> compatible = "simple-bus"; >> #address-cells = <1>; >> #size-cells = <0>; >> pinctrl-0 = <&sata1_pwr_pin &sata2_pwr_pin>; >> pinctrl-names = "default"; >> ... > > Well, even if it works the pinctrl should be claimed by the device that > actually depends on it, i.e. the regulator itself. > >> If that's erroneous we should fix armada-370-synology-ds213j.dts as well. > > Most likely nobody ever noticed if that didn't work because (a) usually > gpio functions are setup by the bootloader or (b) gpio is default reset > value of the pinctrl registers anyway. > > I'd say move the pinctrl properties to regulator nodes for dns-327l now > and we move the properties for ds213j in a separate patch. Usually the merge windows for arm-soc is closed when the rc6 is released which should happen at the end of this week. If you manged to send a new version this week, then I will apply it on mvebu/dt and it should be part of our next pull request. Thanks, Gregory > > Sebastian > >>>> + >>>> + usb_power: regulator@1 { >>>> + compatible = "regulator-fixed"; >>>> + reg = <1>; >>>> + regulator-name = "USB3.0 Port Power"; >>>> + regulator-min-microvolt = <5000000>; >>>> + regulator-max-microvolt = <5000000>; >>>> + enable-active-high; >>>> + regulator-boot-on; >>>> + regulator-always-on; >>>> + gpio = <&gpio0 13 GPIO_ACTIVE_HIGH>; >>> >>> Instead you'll have to put the corresponding pinctrl-0/names properties >>> in each of the regulator nodes, i.e. >>> >>> pinctrl-0 = <&xhci_pwr_pin> >>> pinctrl-names = "default"; >>> >>> here and similar for the other regulator nodes. >>> >>>> + }; >>>> + >>>> + sata_r_power: regulator@2 { >>>> + compatible = "regulator-fixed"; >>>> + reg = <2>; >>>> + regulator-name = "SATA-R Power"; >>>> + regulator-min-microvolt = <5000000>; >>>> + regulator-max-microvolt = <5000000>; >>>> + startup-delay-us = <2000000>; >>>> + enable-active-high; >>>> + regulator-always-on; >>>> + regulator-boot-on; >>>> + gpio = <&gpio1 22 GPIO_ACTIVE_HIGH>; >>>> + }; >>>> + >>>> + sata_l_power: regulator@3 { >>>> + compatible = "regulator-fixed"; >>>> + reg = <3>; >>>> + regulator-name = "SATA-L Power"; >>>> + regulator-min-microvolt = <5000000>; >>>> + regulator-max-microvolt = <5000000>; >>>> + startup-delay-us = <4000000>; >>>> + enable-active-high; >>>> + regulator-always-on; >>>> + regulator-boot-on; >>>> + gpio = <&gpio1 24 GPIO_ACTIVE_HIGH>; >>>> + }; >>>> + }; >>>> +}; > > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/