Date: Mon, 25 May 2015 15:09:01 +0300
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: David Cohen <david.a.cohen@linux.intel.com>, Felipe Balbi <balbi@ti.com>
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] usb: ulpi: ulpi_init should be executed in
 subsys_initcall
Message-ID: <20150525120901.GA29501@kuha.fi.intel.com>
References: <1432294155-18039-1-git-send-email-baolu.lu@linux.intel.com>
 <20150522160845.GA31627@psi-dev26.jf.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150522160845.GA31627@psi-dev26.jf.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1150
Lines: 38

On Fri, May 22, 2015 at 09:08:45AM -0700, David Cohen wrote:
> Hi,
> 
> On Fri, May 22, 2015 at 07:29:15PM +0800, Lu Baolu wrote:
> > Phy drivers and the ulpi interface providers depend on the
> > registeration of the ulpi bus.  Ulpi registers the bus in
> > module_init(). This could result in a load order issue, i.e.
> 
> It's still not an issue :(
> I'd say "unnecessary probe delays".
> 
> But of cource it's Felipe's call :) Description looks better now.
> 
> BR, David
> 
> > ulpi phy drivers or the ulpi interface providers loading
> > before the bus registeration.
> > 
> > This patch fixes this load order issue by putting ulpi_init
> > in subsys_initcall().
> > 
> > Reported-by: Zhuo Qiuxu <qiuxu.zhuo@intel.com>
> > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

Adding Felipe. FWIW, my ACK in any case:

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>


Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/