Date: Mon, 25 May 2015 15:51:21 +0200
From: Christoph Hellwig <hch@lst.de>
To: Ming Lin <mlin@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, lkml <linux-kernel@vger.kernel.org>,
        Kent Overstreet <kent.overstreet@gmail.com>,
        Jens Axboe <axboe@kernel.dk>, Dongsu Park <dpark@posteo.net>
Subject: Re: [PATCH v4 00/11] simplify block layer based on immutable
	biovecs
Message-ID: <20150525135121.GB25855@lst.de>
References: <1432318723-18829-1-git-send-email-mlin@kernel.org> <20150523141522.GA19470@lst.de> <CAF1ivSbfDwoEWzWFjopXtegXUhfQB4PbApHiM94oBa6cw1JKqA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAF1ivSbfDwoEWzWFjopXtegXUhfQB4PbApHiM94oBa6cw1JKqA@mail.gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1068
Lines: 24

On Sun, May 24, 2015 at 12:37:32AM -0700, Ming Lin wrote:
> > Except for that these changes looks good, and the previous version
> > passed my tests fine, so with some benchmarks you'ĺl have my ACK.
> 
> I'll test it on a 2 sockets server with 10 NVMe drives on Monday.
> I'm going to run fio tests:
> 1. raw NVMe drives direct IO read/write
> 2. ext4 read/write
> 
> Let me know if you have other tests that I can run.

That sounds like a good start, but the most important tests would be
those that will cause a lot of splits with the new code.

E.g. some old ATA devices using the piix driver, some crappy USB
device that just allows 64 sector transfers.  Or maybe it's better
to just simulate the case by dropping max_sectors to ease some pain :)

The other cases is DM/MD ѕtripes or RAID5/6 with small stripe sizes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/