Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751587AbbEYNzP (ORCPT ); Mon, 25 May 2015 09:55:15 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:34625 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001AbbEYNzN (ORCPT ); Mon, 25 May 2015 09:55:13 -0400 Date: Mon, 25 May 2015 16:55:00 +0300 From: Dan Carpenter To: Mateusz Kulikowski Cc: gregkh@linuxfoundation.org, joe@perches.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 04/35] staging: rtl8192e: Mark unaligned memcpy() Message-ID: <20150525135500.GB11588@mwanda> References: <1432223628-1664-1-git-send-email-mateusz.kulikowski@gmail.com> <1432223628-1664-5-git-send-email-mateusz.kulikowski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432223628-1664-5-git-send-email-mateusz.kulikowski@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 680 Lines: 18 On Thu, May 21, 2015 at 05:53:17PM +0200, Mateusz Kulikowski wrote: > Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY > checkpatch.pl warning. > It will prevent accidential "Fix" to ether_addr_copy(). > Hopefully someone is going to fix those properly soon so we won't need the comments? Just put a FIXME in the header file instead of putting comments everywhere the struct members are used. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/