Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751491AbbEYODy (ORCPT ); Mon, 25 May 2015 10:03:54 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:38380 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750994AbbEYODu (ORCPT ); Mon, 25 May 2015 10:03:50 -0400 Date: Mon, 25 May 2015 17:03:36 +0300 From: Dan Carpenter To: Mateusz Kulikowski Cc: gregkh@linuxfoundation.org, joe@perches.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 06/35] staging: rtl8192e: Replace memcmp() with ether_addr_equal_unaligned() Message-ID: <20150525140336.GC11588@mwanda> References: <1432223628-1664-1-git-send-email-mateusz.kulikowski@gmail.com> <1432223628-1664-7-git-send-email-mateusz.kulikowski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432223628-1664-7-git-send-email-mateusz.kulikowski@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1295 Lines: 34 On Thu, May 21, 2015 at 05:53:19PM +0200, Mateusz Kulikowski wrote: > Use dedicated macro to compare ethernet addresses in probe_rq_parse(). > > Signed-off-by: Mateusz Kulikowski > --- > drivers/staging/rtl8192e/rtllib_softmac.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c > index 8689b16..65297a0 100644 > --- a/drivers/staging/rtl8192e/rtllib_softmac.c > +++ b/drivers/staging/rtl8192e/rtllib_softmac.c > @@ -1853,7 +1853,8 @@ static short probe_rq_parse(struct rtllib_device *ieee, struct sk_buff *skb, > return -1; /* corrupted */ > > bssid_match = > - (memcmp(header->addr3, ieee->current_network.bssid, ETH_ALEN) != 0) && > + (!ether_addr_equal_unaligned(header->addr3, > + ieee->current_network.bssid)) && Isn't this aligned? Joe, I really dread these checkpatch.pl patches. It's the kind of thing I hate more as time goes on and not less... regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/