Message-ID: <55633A37.7040404@linux.intel.com>
Date: Mon, 25 May 2015 18:05:27 +0300
From: Mathias Nyman <mathias.nyman@linux.intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Roger Quadros <rogerq@ti.com>, Andrew Bresticker <abrestic@chromium.org>
CC: mathias.nyman@intel.com, Alan Stern <stern@rowland.harvard.edu>,
        gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] usb: xhci: cleanup xhci_hcd allocation
References: <1427977409-7671-1-git-send-email-rogerq@ti.com> <1427977409-7671-2-git-send-email-rogerq@ti.com> <5523E861.7060807@linux.intel.com> <552644DF.6030908@ti.com> <552BBB2B.6010902@linux.intel.com> <5550BA31.10901@ti.com> <55520CA4.9040004@linux.intel.com>
In-Reply-To: <55520CA4.9040004@linux.intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1857
Lines: 46

>>>>
>>>> I've been testing add/remove HCD extensively and didn't observe any issues after applying
>>>> these 5 patches. Well there is one issue that comes up but it has nothing to do with xhci
>>>> not being allocated. It has more to do with command being queued after the HCD has gone away
>>>> and so getting stuck forever without timing out.
>>>
>>> I went through the codepaths and you're right, should work fine. My concern wasn't valid.
>>> This patchset doesn't even touch the order how primary and shared HCDs are created and added
>>> in the PCI case, only for the platform device case.
>>>
>>> I'll try it out and send forward once rc1 is out.
>>
>> did you get a chance to try this series?
>>
> 
> Sorry, not yet, got delayed by other internal tasks.
> I'll try it out as soon as possible.
> 
>

Ok, back to this, I'd like to get both this series and Andrew's xhci-tegra
support to 4.2

I did similar changes to xhci-tegra.c as Roger did to xhci-pci.c and xhci-plat.c,
but I can't test them and would need both your eyes on this to make sure it looks ok.

Both series are in a tegra_otg_merge topic branch in:
  
git://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git tegra_otg_merge

It contains Andrews full xhci tegra support series, but If I understood correctly only
patch 9/9 (maybe 8/9 as well?) will actually go through the xhci tree. 
Patch 1/9 is not needed with Roger's changes anymre  

The changes are in the last patch, here:
https://git.kernel.org/cgit/linux/kernel/git/mnyman/xhci.git/commit/?h=tegra_otg_merge

and would be squashed together with patch 9/9.

Thanks
Mathias 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/