Date: Mon, 25 May 2015 17:18:59 +0200 (CEST)
From: Jiri Kosina <jkosina@suse.cz>
To: Minfei Huang <mnfhuang@gmail.com>
cc: jpoimboe@redhat.com, sjenning@redhat.com, vojtech@suse.cz,
        live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
        mhuang@redhat.com
Subject: Re: [Patch v2] livepatch: annotate klp_init() with __init
In-Reply-To: <1432304789-6324-1-git-send-email-mnfhuang@gmail.com>
Message-ID: <alpine.LNX.2.00.1505251716550.13817@pobox.suse.cz>
References: <1432304789-6324-1-git-send-email-mnfhuang@gmail.com>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1149
Lines: 34

On Fri, 22 May 2015, Minfei Huang wrote:

> Usually we prefer to let compiler put the module initialized function to
> section ".init.text". Thus this text in memory will be freed in future.
> 
> Once we add the "__init" preceding function name, we can use following
> command to find it in specfied section.
> 
>   $ objdump -t -j .init.text built-in.o
> 
>   built-in.o:     file format elf64-x86-64
> 
>   SYMBOL TABLE:
>   0000000000000000 l    d  .init.text	0000000000000000 .init.text
>   0000000000000000 l     F .init.text	000000000000004e klp_init
> 
> Signed-off-by: Minfei Huang <mnfhuang@gmail.com>

I think this changelog is way too verbose for no good reason (this is 
probably the first time in my life I am saying something like that :) ).

There is really no need to explain how to use objdump in changelog. I've 
shortened the changelog and applied.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/