Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751229AbbEYQQs (ORCPT ); Mon, 25 May 2015 12:16:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45559 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750859AbbEYQQr (ORCPT ); Mon, 25 May 2015 12:16:47 -0400 Date: Mon, 25 May 2015 09:16:47 -0700 From: Greg KH To: Nikhil Badola Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers:usb:fsl: Replace macros with enumerated type Message-ID: <20150525161647.GD9772@kroah.com> References: <1432534294-20375-1-git-send-email-nikhil.badola@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432534294-20375-1-git-send-email-nikhil.badola@freescale.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1579 Lines: 50 On Mon, May 25, 2015 at 11:41:34AM +0530, Nikhil Badola wrote: > Replace macros with enumerated type to represent usb ip controller > version > > Signed-off-by: Nikhil Badola > --- > Depends on "drivers: usb :fsl: Add support for USB controller version-2.5" > > include/linux/fsl_devices.h | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/include/linux/fsl_devices.h b/include/linux/fsl_devices.h > index 2a2f56b..035ead7 100644 > --- a/include/linux/fsl_devices.h > +++ b/include/linux/fsl_devices.h > @@ -20,11 +20,6 @@ > #define FSL_UTMI_PHY_DLY 10 /*As per P1010RM, delay for UTMI > PHY CLK to become stable - 10ms*/ > #define FSL_USB_PHY_CLK_TIMEOUT 10000 /* uSec */ > -#define FSL_USB_VER_OLD 0 > -#define FSL_USB_VER_1_6 1 > -#define FSL_USB_VER_2_2 2 > -#define FSL_USB_VER_2_4 3 > -#define FSL_USB_VER_2_5 4 > > #include > > @@ -52,6 +47,14 @@ > * > */ > > +enum fsl_usb2_controller_ver { > + FSL_USB_VER_OLD, > + FSL_USB_VER_1_6, > + FSL_USB_VER_2_2, > + FSL_USB_VER_2_4, > + FSL_USB_VER_2_5, Don't you need to specify the value here just to be "sure" the compiler gets it correct, and so that someone knows they can't add a new value in the middle? And why didn't you cc: the linux-usb mailing list? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/