Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751174AbbEYRdO (ORCPT ); Mon, 25 May 2015 13:33:14 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:55765 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903AbbEYRdK (ORCPT ); Mon, 25 May 2015 13:33:10 -0400 Date: Mon, 25 May 2015 18:32:44 +0100 From: Mark Brown To: Tomeu Vizoso Cc: linux-arm-kernel@lists.infradead.org, =?iso-8859-1?Q?St=E9phane?= Marchesin , Thierry Reding , Dmitry Torokhov , Alexander Holler , Grant Likely , Rob Herring , Mark Rutland , Liam Girdwood , linux-kernel@vger.kernel.org Message-ID: <20150525173244.GE21577@sirena.org.uk> References: <1432565608-26036-1-git-send-email-tomeu.vizoso@collabora.com> <1432565608-26036-11-git-send-email-tomeu.vizoso@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Hb0QVqIhF4gpPBBD" Content-Disposition: inline In-Reply-To: <1432565608-26036-11-git-send-email-tomeu.vizoso@collabora.com> X-Cookie: Positively no smoking. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 10/21] regulator: core: Probe regulators on demand X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1842 Lines: 48 --Hb0QVqIhF4gpPBBD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 25, 2015 at 04:53:14PM +0200, Tomeu Vizoso wrote: > When looking up a regulator through its DT node, ensure that the > corresponding device has been registered. I'm sorry but I'm going to need a much better changelog to review this patch. I can't entirely tell what the intended effect is supposed to be, the subject line says we're probing things and the body says we're registering things which aren't the same thing at all. > if (node) { > + of_platform_device_ensure(node); This function doesn't appear in git so I'm guessing that some other patch in the series adds it. See my reply to the first patch... The obvious questions here based on the name are why we're doing something specific to platform devices and why this isn't something we're abstracting in the driver core (or at least generic firmware code) - we're going to have the same thing with ACPI. --Hb0QVqIhF4gpPBBD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVY1y7AAoJECTWi3JdVIfQjGoIAIENspQ5VptP7YdQXbF4Fw3I LTHjCzV0m98dK1mmTyNJ2R2p1gQ89T7E26iUnp5Rof8Y37IU9VcrOTnrFCyW3qQ0 vurtRR/aBE/7PfomKeHuQzMAZyVXMGD5O2qTB6HQUGcQZPK4K553UMbAePCoPJPM NTIiHLasOrZHn7+CDo+sItPBxfcn9oE1yMpn76rIWFFH8Zt4NVNKVeZgf1vAJYRH jr4ZmmkZrIi8o71N7/zsA7hy3m55ioMMsL+/h8vRwbT1MjFZ+GWZdTHG/mz5PNZo mojZcFEJTERbAUQutz3O/emQa7634Fwqs7N8f61d0Lf7mJE1gWBb4yZJfTLD980= =mKLg -----END PGP SIGNATURE----- --Hb0QVqIhF4gpPBBD-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/