Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751293AbbEYRgs (ORCPT ); Mon, 25 May 2015 13:36:48 -0400 Received: from netrider.rowland.org ([192.131.102.5]:48381 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750732AbbEYRgo (ORCPT ); Mon, 25 May 2015 13:36:44 -0400 Date: Mon, 25 May 2015 13:36:43 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Andy Shevchenko cc: "Rafael J. Wysocki" , , , Greg Kroah-Hartman , Vinod Koul , Lee Jones , Andrew Morton , Mika Westerberg , , , Heikki Krogerus , Jarkko Nikula Subject: Re: [PATCH v2 3/8] core: platform: wakeup the parent before trying any driver operations In-Reply-To: <1432570172-86963-4-git-send-email-andriy.shevchenko@linux.intel.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1055 Lines: 30 On Mon, 25 May 2015, Andy Shevchenko wrote: > From: Heikki Krogerus > > If the parent is still suspended when a driver probe, > remove or shutdown is attempted, the result may be a > failure. > > For example, if the parent is a PCI MFD device that has been > suspended when we try to probe our device, any register > reads will return 0xffffffff. > > To fix the problem, making sure the parent is always awake > before using driver probe, remove or shutdown. > > Signed-off-by: Heikki Krogerus > Signed-off-by: Andy Shevchenko > --- > drivers/base/platform.c | 21 ++++++++++++++++++++- Why make the changes here rather than in dd.c? Is there something special about platform devices? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/