Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751547AbbEYRot (ORCPT ); Mon, 25 May 2015 13:44:49 -0400 Received: from relay.parallels.com ([195.214.232.42]:44013 "EHLO relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750881AbbEYRor (ORCPT ); Mon, 25 May 2015 13:44:47 -0400 Message-ID: <1432575881.6866.36.camel@odin.com> Subject: [PATCH RFC 04/13] exit: Small refactoring mm_update_next_owner() From: Kirill Tkhai To: CC: Oleg Nesterov , Andrew Morton , Ingo Molnar , "Peter Zijlstra" , Michal Hocko , "Rik van Riel" , Ionut Alexa , Peter Hurley , Kirill Tkhai Date: Mon, 25 May 2015 20:44:41 +0300 In-Reply-To: <20150525162722.5171.15901.stgit@pro> References: <20150525162722.5171.15901.stgit@pro> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.30.16.109] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1525 Lines: 62 This will be used in next patches. No functionality change. Signed-off-by: Kirill Tkhai --- kernel/exit.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/kernel/exit.c b/kernel/exit.c index a1b2bf7..5e82787 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -322,16 +322,20 @@ void mm_update_next_owner(struct mm_struct *mm) * Search in the children */ list_for_each_entry(c, &p->children, sibling) { - if (c->mm == mm) + if (c->mm == mm) { + get_task_struct(c); goto assign_new_owner; + } } /* * Search in the siblings */ list_for_each_entry(c, &p->real_parent->children, sibling) { - if (c->mm == mm) + if (c->mm == mm) { + get_task_struct(c); goto assign_new_owner; + } } /* @@ -341,8 +345,10 @@ void mm_update_next_owner(struct mm_struct *mm) if (g->flags & PF_KTHREAD) continue; for_each_thread(g, c) { - if (c->mm == mm) + if (c->mm == mm) { + get_task_struct(c); goto assign_new_owner; + } if (c->mm) break; } @@ -358,7 +364,6 @@ void mm_update_next_owner(struct mm_struct *mm) assign_new_owner: BUG_ON(c == p); - get_task_struct(c); /* * The task_lock protects c->mm from changing. * We always want mm->owner->mm == mm -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/