Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751150AbbEYTYz (ORCPT ); Mon, 25 May 2015 15:24:55 -0400 Received: from mail-vn0-f50.google.com ([209.85.216.50]:41450 "EHLO mail-vn0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750894AbbEYTYx (ORCPT ); Mon, 25 May 2015 15:24:53 -0400 MIME-Version: 1.0 In-Reply-To: <1432581494-4738-1-git-send-email-shailendra.capricorn@gmail.com> References: <1432581494-4738-1-git-send-email-shailendra.capricorn@gmail.com> Date: Mon, 25 May 2015 21:24:52 +0200 Message-ID: Subject: Re: [PATCH] char:agp:amd64-agp - Change 1 to true for bool type From: Richard Weinberger To: Shailendra Verma Cc: David Airlie , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1351 Lines: 39 On Mon, May 25, 2015 at 9:18 PM, Shailendra Verma wrote: > The variable agp_try_unsupported is bool type.Hence initializing > with true instead of 1. Also fixing the below checkpatch warning. Please one logical change per patch. > WARNING: __initdata should be placed after agp_try_unsupported > FILE: drivers/char/agp/amd64-agp.c:36: > static bool __initdata agp_try_unsupported = true; > > Signed-off-by: Shailendra Verma > --- > drivers/char/agp/amd64-agp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c > index 0ef3500..14900ea 100644 > --- a/drivers/char/agp/amd64-agp.c > +++ b/drivers/char/agp/amd64-agp.c > @@ -33,7 +33,7 @@ > #define ULI_X86_64_ENU_SCR_REG 0x54 > > static struct resource *aperture_resource; > -static bool __initdata agp_try_unsupported = 1; > +static bool agp_try_unsupported __initdata = true; What issue does this fix? IOW why is assigning 1 wrong? > static int agp_bridges_found; -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/