Message-ID: <5563928C.1030002@nod.at>
Date: Mon, 25 May 2015 23:22:20 +0200
From: Richard Weinberger <richard@nod.at>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Shailendra Verma <shailendra.capricorn@gmail.com>
CC: David Airlie <airlied@linux.ie>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] char:agp:amd64-agp - Change 1 to true for bool type
References: <1432581494-4738-1-git-send-email-shailendra.capricorn@gmail.com>	<CAFLxGvwdyKG7B=pbHLJWkySsbdX-jnShT+wcOxTfy3=nMeKvZg@mail.gmail.com> <CA+tKcn-jTHbzk2FGhfxQA6wGQqY+JWRS6S4+BJmWhkwt3ppWqQ@mail.gmail.com>
In-Reply-To: <CA+tKcn-jTHbzk2FGhfxQA6wGQqY+JWRS6S4+BJmWhkwt3ppWqQ@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 867
Lines: 21

Am 25.05.2015 um 23:14 schrieb Shailendra Verma:
> Hello Richard,
> 
> I will separate both the changes and will send the patches to you.
> 
> What issue does this fix? IOW why is assigning 1 wrong?
> 
>>>>> Yes, you are correct. There will be no issue in assigning 1 to the variable. But according to coding guidelines we should only use true/false for bool type variables.

Really? I don't see this in Documentation/CodingStyle and checkpatch.pl does not bark either.
IMHO it is a matter of taste. But the individual maintainer has to decide. :-)

Thanks,
//richard

P.s: Please don't crop the list of CC when replying.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/