Date: Mon, 25 May 2015 17:28:18 -0400 (EDT)
Message-Id: <20150525.172818.2000334376621437405.davem@davemloft.net>
To: linus.luessing@c0d3.blue
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, stephen@networkplumber.org,
        herbert@gondor.apana.org.au, roopa@cumulusnetworks.com,
        cwang@twopensource.com, sashok@cumulusnetworks.com,
        wkok@cumulusnetworks.com
Subject: Re: [PATCHv3 net-next] bridge: allow setting hash_max +
 multicast_router if interface is down
From: David Miller <davem@davemloft.net>
In-Reply-To: <1432343554-3493-1-git-send-email-linus.luessing@c0d3.blue>
References: <1432343554-3493-1-git-send-email-linus.luessing@c0d3.blue>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 966
Lines: 22

From: Linus L?ssing <linus.luessing@c0d3.blue>
Date: Sat, 23 May 2015 03:12:34 +0200

> Network managers like netifd (used in OpenWRT for instance) try to
> configure interface options after creation but before setting the
> interface up.
> 
> Unfortunately the sysfs / bridge currently only allows to configure the
> hash_max and multicast_router options when the bridge interface is up.
> But since br_multicast_init() doesn't start any timers and only sets
> default values and initializes timers it should be save to reconfigure
> the default values after that, before things actually get active after
> the bridge is set up.
> 
> Signed-off-by: Linus L?ssing <linus.luessing@c0d3.blue>

Applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/