Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751710AbbEYVju (ORCPT ); Mon, 25 May 2015 17:39:50 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:46967 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127AbbEYVjr (ORCPT ); Mon, 25 May 2015 17:39:47 -0400 Date: Mon, 25 May 2015 17:39:46 -0400 (EDT) Message-Id: <20150525.173946.265552397243249712.davem@davemloft.net> To: hofrat@osadl.org Cc: samuel@sortiz.org, joe@perches.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] irda: irda-usb: use msecs_to_jiffies for conversions From: David Miller In-Reply-To: <1432385190-6333-1-git-send-email-hofrat@osadl.org> References: <1432385190-6333-1-git-send-email-hofrat@osadl.org> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 25 May 2015 14:39:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1051 Lines: 27 From: Nicholas Mc Guire Date: Sat, 23 May 2015 14:46:30 +0200 > API compliance scanning with coccinelle flagged: > > Converting milliseconds to jiffies by "val * HZ / 1000" is technically > is not a clean solution as it does not handle all corner cases correctly. > By changing the conversion to use msecs_to_jiffies(val) conversion is > correct in all cases. > > in the current code: > mod_timer(&self->rx_defer_timer, jiffies + (10 * HZ / 1000)); > for HZ < 100 (e.g. CONFIG_HZ == 64|32 in alpha) this effectively results > in no delay at all. > > Patch was compile tested for x86_64_defconfig (implies CONFIG_USB_IRDA=m) > > Patch is against 4.1-rc4 (localversion-next is -next-20150522) > > Signed-off-by: Nicholas Mc Guire Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/