Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751262AbbEYWOX (ORCPT ); Mon, 25 May 2015 18:14:23 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:57863 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750894AbbEYWOU (ORCPT ); Mon, 25 May 2015 18:14:20 -0400 Message-ID: <1432592058.722.14.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH-v2 1/9] target: Convert se_node_acl->device_list[] to RCU hlist From: "Nicholas A. Bellinger" To: Christoph Hellwig Cc: Christoph Hellwig , "Nicholas A. Bellinger" , target-devel , linux-scsi , linux-kernel , Hannes Reinecke , Sagi Grimberg , "Paul E. McKenney" Date: Mon, 25 May 2015 15:14:18 -0700 In-Reply-To: <20150522113119.GA28758@lst.de> References: <1432275071-28882-1-git-send-email-nab@daterainc.com> <1432275071-28882-2-git-send-email-nab@daterainc.com> <20150522082411.GB5384@infradead.org> <1432284930.898.19.camel@haakon3.risingtidesystems.com> <20150522113119.GA28758@lst.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2774 Lines: 73 On Fri, 2015-05-22 at 13:31 +0200, Christoph Hellwig wrote: > On Fri, May 22, 2015 at 01:55:30AM -0700, Nicholas A. Bellinger wrote: > > > This update will now be racy, ditto for the read/write_bytes update > > > later. > > > > This should become an atomic_long_t increment, yes..? > > Yes. Converted. > > > Yes, this helper is from your patch above. > > > > Considering there is a single user of it here, and complexities involved > > for a RCU conversion + bisect, is it really work adding as a separate > > patch ahead of this one..? > > The golden Linus style is to put preparatory patches first so that the > actual logic change is as small as possible. Adding helpers so that > low level accesses that will e changed soon is a very typical case for that. > That would be applicable here, if the patch in question had anything to do with the actual RCU conversion itself. Since it doesn't, I'll keep it as a separate patch after the RCU specific changes, along with the other improvements. > > > > + kref_put(&orig->pr_kref, target_pr_kref_release); > > > > + wait_for_completion(&orig->pr_comp); > > > > > > > > > > > + kref_put(&orig->pr_kref, target_pr_kref_release); > > > > /* > > > > - * Disable struct se_dev_entry LUN ACL mapping > > > > + * Before fireing off RCU callback, wait for any in process SPEC_I_PT=1 > > > > + * or REGISTER_AND_MOVE PR operation to complete. > > > > */ > > > > + wait_for_completion(&orig->pr_comp); > > > > + kfree_rcu(orig, rcu_head); > > > > > > The release callback should just call kfree_rcu, no need to wait for the > > > release in the caller. > > > > > > > Why doesn't se_dev_entry release this need to wait for the special case > > references to drop..? > > Why would it? It originally had to wait in order for the se_dev_entry consumers to drop, before it could be reused in se_node_acl->device_list[].. > There is no access to the structure at this point, so there > is no point to keep it around localy. If there were other references to > it they by defintion don't need it anymore by the time they drop the > reference count. Freeing a structure as soon as the refcount drops > zero is the normal style all over the place. Waiting for a reference > count only makes sense if it's a drain style operation where you don't > free the structure but you just want to wait for some class of consumers > to stop using it. .. but since it's not being reused anymore, doing a kfree_rcu() from the final kref_put() should be fine. Converting now. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/