Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751727AbbEZGPE (ORCPT ); Tue, 26 May 2015 02:15:04 -0400 Received: from mail.lang.hm ([64.81.33.126]:58856 "EHLO bifrost.lang.hm" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751679AbbEZGPA (ORCPT ); Tue, 26 May 2015 02:15:00 -0400 Date: Mon, 25 May 2015 23:04:39 -0700 (PDT) From: David Lang X-X-Sender: dlang@asgard.lang.hm To: Daniel Phillips cc: Rik van Riel , Jan Kara , linux-fsdevel@vger.kernel.org, tux3@tux3.org, linux-kernel@vger.kernel.org, OGAWA Hirofumi Subject: Re: [FYI] tux3: Core changes In-Reply-To: Message-ID: References: <8f886f13-6550-4322-95be-93244ae61045@phunq.net> <55545C2F.8040207@phunq.net> <20150519140045.GA16313@quack.suse.cz> <555B8C79.4090909@phunq.net> <20150520144429.GA17783@quack.suse.cz> <555CB4B6.8050305@phunq.net> <555CE62C.5030202@redhat.com> <555D0FDF.3070303@phunq.net> <555D500B.4080901@phunq.net> <13c8bcdf-70e8-43d5-a05f-58ad839dbfd0@phunq.net> <5563F5C8.2040806@redhat.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1546 Lines: 35 On Mon, 25 May 2015, Daniel Phillips wrote: > On Monday, May 25, 2015 9:25:44 PM PDT, Rik van Riel wrote: >> On 05/21/2015 03:53 PM, Daniel Phillips wrote: >>> On Wednesday, May 20, 2015 8:51:46 PM PDT, David Lang wrote: >>>> how do you prevent it from continuing to interact with the old version >>>> of the page and never see updates or have it's changes reflected on >>>> the current page? >>> >>> Why would it do that, and what would be surprising about it? Did >>> you have a specific case in mind? >> >> After a get_page(), page_cache_get(), or other equivalent >> function, a piece of code has the expectation that it can >> continue using that page until after it has released the >> reference count. >> >> This can be an arbitrarily long period of time. > > It is perfectly welcome to keep using that page as long as it > wants, Tux3 does not care. When it lets go of the last reference > (and Tux3 has finished with it) then the page is freeable. Did > you have a more specific example where this would be an issue? > Are you talking about kernel or userspace code? if the page gets modified again, will that cause any issues? what if the page gets modified before the copy gets written out, so that there are two dirty copies of the page in the process of being written? David Lang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/