Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751522AbbEZH06 (ORCPT ); Tue, 26 May 2015 03:26:58 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:64436 "EHLO imgpgp01.kl.imgtec.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751236AbbEZH0z (ORCPT ); Tue, 26 May 2015 03:26:55 -0400 X-PGP-Universal: processed; by imgpgp01.kl.imgtec.org on Tue, 26 May 2015 08:26:53 +0100 Date: Tue, 26 May 2015 08:25:48 +0100 From: Paul Burton To: Hauke Mehrtens CC: , Ian Campbell , Kumar Gala , Lars-Peter Clausen , Mark Rutland , Pawel Moll , "Ralf Baechle" , Rob Herring , , Joshua Kinard , "Leonid Yegoshin" , Deng-Cheng Zhu , , Markos Chandras , Andreas Herrmann Subject: Re: [PATCH v5 36/37] MIPS: ingenic: initial JZ4780 support Message-ID: <20150526072548.GS13811@NP-P-BURTON> References: <1432480307-23789-1-git-send-email-paul.burton@imgtec.com> <1432480307-23789-37-git-send-email-paul.burton@imgtec.com> <5563019A.2050702@hauke-m.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ISKrrfpKsPiF35CV" Content-Disposition: inline In-Reply-To: <5563019A.2050702@hauke-m.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [192.168.159.140] X-ESG-ENCRYPT-TAG: b93fcccb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2832 Lines: 82 --ISKrrfpKsPiF35CV Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 25, 2015 at 01:03:54PM +0200, Hauke Mehrtens wrote: > > diff --git a/arch/mips/jz4740/setup.c b/arch/mips/jz4740/setup.c > > index 1bed3cb..510fc0d 100644 > > --- a/arch/mips/jz4740/setup.c > > +++ b/arch/mips/jz4740/setup.c > > @@ -83,6 +83,9 @@ arch_initcall(populate_machine); > > =20 > > const char *get_system_type(void) > > { > > + if (config_enabled(CONFIG_MACH_JZ4780)) > > + return "JZ4780"; > > + > > return "JZ4740"; > > } >=20 > Shouldn't this be provided by device tree, now it depends on your kernel > config. At some point, when the kernel is generic enough that one binary works across multiple SoCs, yes definitely. Even better might be to detect it at runtime. The kernel can currently only be built for a single SoC though, so the code as-is works just fine & gets things working on the CI20 without making an already lengthy patchset longer than it needs to be. > > diff --git a/arch/mips/jz4740/time.c b/arch/mips/jz4740/time.c > > index 9172553..7ab47fe 100644 > > --- a/arch/mips/jz4740/time.c > > +++ b/arch/mips/jz4740/time.c > > @@ -102,7 +102,12 @@ static struct clock_event_device jz4740_clockevent= =3D { > > .set_next_event =3D jz4740_clockevent_set_next, > > .set_mode =3D jz4740_clockevent_set_mode, > > .rating =3D 200, > > +#ifdef CONFIG_MACH_JZ4740 > > .irq =3D JZ4740_IRQ_TCU0, > > +#endif > > +#ifdef CONFIG_MACH_JZ4780 > > + .irq =3D JZ4780_IRQ_TCU2, > > +#endif > > }; >=20 > same here. Same response :) Thanks, Paul --ISKrrfpKsPiF35CV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVZB/3AAoJENzvn0paErs5TjQP/3jxzdlliT7qvgmEycMweXzh h706mxyUxYhg2PzAzH7XMqFXGUShi/vy6RZkp0Sj1b8A4nnvpISQWXpC+V8mooAJ xyxVuZFvVRdDMLcKD/Rw9a4k2kgsOdwkIaLSmqLUN+HAMbjCl5kzpvTGBrQh8Rwi dwMl/hB/9rHf4dX4YbMXwgy2e3iBHoeNzfkCC5To5NC5yiDnO0dZRskMOlKS4LE2 lwgxMJcO7aMGs6Q/nRE8TocVYi+4GLRl9dnPSu4hag8PZokd91yF+ZmAuuXwa97u stW5SHIcdABgPPbdsyXSUlbw4mguohY1ZQYXvKXrE11Acpl3FpWn74LUvx+I1qtg 2NNbIsj4Iklm0KltwouNdZuFMBM1AZweJ7vNmOaOWP3KV0fNA7WtxdBVGYCOtLvv qsCJ3Y6t8i8s9JKJ1/7C4HKlDnSercgYG81nMprnPr16dcUtAyHchj/uPB0BBPgW RInzipmWTMO8K7+0VrvU3gModh290VkuMgFtl9iIVT+wMhdqb+Y/BKThZTYC69OB GxyIwVqB2xN2qVT1n6ZKRbSBL8JvQRhWxIANabpHR21IH9buzuRobjOrqq8pugtT Z5nRoKDGG3iZoZbPLVA5JGZSmj1n+vQ4v3woI+084FVIVCa92eHRbLYDeFilCT5h A6l+tI8FbTYEsnO+t7Sn =Huf8 -----END PGP SIGNATURE----- --ISKrrfpKsPiF35CV-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/