Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751913AbbEZHcu (ORCPT ); Tue, 26 May 2015 03:32:50 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:35113 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751425AbbEZHcq (ORCPT ); Tue, 26 May 2015 03:32:46 -0400 Message-ID: <5564219B.9040406@suse.cz> Date: Tue, 26 May 2015 09:32:43 +0200 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Minfei Huang , Li Bin CC: Jiri Kosina , Nicholas Mc Guire , Josh Poimboeuf , Seth Jennings , Vojtech Pavlik , "live-patching@vger.kernel.org" , "linux-kernel@vger.kernel.org" , xiexiuqi , Hanjun Guo , "mhuang@redhat.com" Subject: Re: [PATCH] livepatch: match function return value type with prototype References: <1431323549-27343-1-git-send-email-hofrat@osadl.org> <5563DE28.4070100@huawei.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2379 Lines: 60 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 05/26/2015, 06:46 AM, Minfei Huang wrote: > On Tue, May 26, 2015 at 10:44 AM, Li Bin > wrote: >> The klp_is_module return type should be boolean. >> >> Signed-off-by: Li Bin --- >> kernel/livepatch/core.c | 2 +- 1 files changed, 1 >> insertions(+), 1 deletions(-) >> >> diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c >> index 284e269..30e9339 100644 --- a/kernel/livepatch/core.c +++ >> b/kernel/livepatch/core.c @@ -78,7 +78,7 @@ static struct klp_ops >> *klp_find_ops(unsigned long old_addr) >> >> static bool klp_is_module(struct klp_object *obj) { - >> return obj->name; + return !!obj->name; } > > Hi, Bin. > > Does compile blame the prototype before you convert it? If not, I > think we do not need to fix it, since there are a lot of places in > kernel where we return point value as boolean. Yes, but the real reason is not that we use it on a lot of places, but that it is standardized in ΒΆ 6.3.1.2: When any scalar value is converted to _Bool, the result is 0 if the value compares equal to 0; otherwise, the result is 1. Along with the definition of scalar types: Arithmetic types and pointer types are collectively called scalar types. thanks, - -- js suse labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVZCGXAAoJEL0lsQQGtHBJMCEP/AufUwrMFZ7KTD/pWKpjpDlu fP8eflJ7iBxGtHXe9PGOsthY4kd1mB+kCo+54N1gks9bbnWF6P302hck5zrBHBdH /wbo7YXhbHicUNAXZUzxfDh3nkKmR96CIeqZhMp2H1UBzmGRKzd6kVSdBwlbJ0/W ZNcWmiIaALdr7aMEw+qEExV35kUdbJaqUcHKC9in3qQtlzCVQbZ5mCqURe+61ZTL 9u/Sbf3vB+nJPzyC/8uSVAxF616PiPdgGvxRrrRrRH82JmRaVJFjsRJ1WeMNxOFt s4gbNByNePmTG3SisqFFKQ6VJYyeEsxkeRKbvL2mW4IlzJjiWCbp6XHcv2/IzR9g GdIu3Kgy5R0OBXTxMbb5VLVtDRZUYnD/HiOFVLdUiqI6HQ/MtdZGujnVhWAVGIse BD8T+hTOQyt6Yk7evlEF+REOlAU8jvBvnq3PUfRlUjWso8w0giPx1Re6rQk4k39P TmfIVrve79n2nR/OejeCAB3xBEDtFbKBg9I+5ONm1gogxz/+3o6mwfMGS8TSdNs9 l4Kl/dhQhSW3aOmrclUoOZpcAzfTJSNCepTFq6+hKIbKibtnKs63wkLnGyL+XZSE dEOWBC/B5YNC9VVAm20U8jAtUS5gw3n0NpXFTxOi0nb62IGY+mT+D5pPylVn31Rq H7FDzgpZ7+lyvx+FDqpv =UzJg -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/