Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751827AbbEZISJ (ORCPT ); Tue, 26 May 2015 04:18:09 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:36338 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751388AbbEZISF (ORCPT ); Tue, 26 May 2015 04:18:05 -0400 Date: Tue, 26 May 2015 10:20:26 +0200 From: Daniel Vetter To: Chris Wilson , Daniel Vetter , Intel Graphics Development , LKML , Jani Nikula , Andrew Morton , Daniel Vetter Subject: Re: [PATCH] Revert "drm/i915: Force clean compilation with -Werror" Message-ID: <20150526082026.GG12971@phenom.ffwll.local> Mail-Followup-To: Chris Wilson , Intel Graphics Development , LKML , Jani Nikula , Andrew Morton , Daniel Vetter References: <1432619242-13138-1-git-send-email-daniel.vetter@ffwll.ch> <20150526075713.GB20703@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150526075713.GB20703@nuc-i3427.alporthouse.com> X-Operating-System: Linux phenom 4.0.0-rc3+ User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1023 Lines: 24 On Tue, May 26, 2015 at 08:57:13AM +0100, Chris Wilson wrote: > On Tue, May 26, 2015 at 07:47:22AM +0200, Daniel Vetter wrote: > > This reverts commit 118182e9d7d5afa0c7c10f568afb46ab78b462e9. > > > > It's causing too much trouble when compile-testing for non-i915 folks. > > What's the argument against using COMPILE_TEST as a proxy for detecting > all(yes|mod)config as in Damien's patch? I also thought about random users bisecting who'll then also might trip over this. Figure that overall the benefit isn't good enough given the trouble this seems to have caused immediately. 0-day is pretty fast at screaming around about new compiler warnings anyway, for the cases where I miss them. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/