Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752286AbbEZIbD (ORCPT ); Tue, 26 May 2015 04:31:03 -0400 Received: from [210.61.82.183] ([210.61.82.183]:54890 "EHLO mailgw01.mediatek.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751566AbbEZIaB (ORCPT ); Tue, 26 May 2015 04:30:01 -0400 X-Listener-Flag: 11101 Message-ID: <1432628943.11070.2.camel@mtksdaap41> Subject: Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support From: Yingjoe Chen To: Sascha Hauer CC: YH Huang , Mark Rutland , , , Pawel Moll , "open list:OPEN FIRMWARE AND..." , "linux-kernel@vger.kernel.org" , Rob Herring , "Thierry Reding" , Sascha Hauer , Matthias Brugger , , "linux-arm-kernel@lists.infradead.org" Date: Tue, 26 May 2015 16:29:03 +0800 In-Reply-To: <20150526060533.GW6325@pengutronix.de> References: <1431336382-13167-1-git-send-email-yh.huang@mediatek.com> <1431336382-13167-3-git-send-email-yh.huang@mediatek.com> <1432196551.15653.2.camel@mtksdaap41> <20150526060533.GW6325@pengutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1161 Lines: 35 On Tue, 2015-05-26 at 08:05 +0200, Sascha Hauer wrote: > On Thu, May 21, 2015 at 04:22:31PM +0800, YH Huang wrote: > > On Mon, 2015-05-18 at 11:42 +0800, Daniel Kurtz wrote: <...> > > > On Mon, May 11, 2015 at 5:26 PM, YH Huang wrote: > > > > + > > > > +static const struct of_device_id mtk_disp_pwm_of_match[] = { > > > > + { .compatible = "mediatek,mt6595-disp-pwm" }, > > > > > > Does this driver support the PWM in mt8173? > > > If so, don't you need this, too: > > > > > > { .compatible = "mediatek,mt8173-disp-pwm" }, > > > > Yes, it supports mt8173. > > I will add it. > > If both yre compatible you don't need to add it since you have a > "mediatek,mt6595-disp-pwm" in the mt8173 device tree. Hi Sascha, We got a similar discussion about this with Mark Brown for spi driver, please see: http://lists.infradead.org/pipermail/linux-mediatek/2015-May/000673.html Joe.C -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/