Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751181AbbEZIkb (ORCPT ); Tue, 26 May 2015 04:40:31 -0400 Received: from mail.fireflyinternet.com ([87.106.93.118]:49488 "EHLO fireflyinternet.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750726AbbEZIk1 (ORCPT ); Tue, 26 May 2015 04:40:27 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Tue, 26 May 2015 09:39:56 +0100 From: Chris Wilson To: Intel Graphics Development , LKML , Jani Nikula , Andrew Morton , Daniel Vetter Subject: Re: [PATCH] Revert "drm/i915: Force clean compilation with -Werror" Message-ID: <20150526083956.GC20703@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , Intel Graphics Development , LKML , Jani Nikula , Andrew Morton , Daniel Vetter References: <1432619242-13138-1-git-send-email-daniel.vetter@ffwll.ch> <20150526075713.GB20703@nuc-i3427.alporthouse.com> <20150526082026.GG12971@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150526082026.GG12971@phenom.ffwll.local> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1234 Lines: 27 On Tue, May 26, 2015 at 10:20:26AM +0200, Daniel Vetter wrote: > On Tue, May 26, 2015 at 08:57:13AM +0100, Chris Wilson wrote: > > On Tue, May 26, 2015 at 07:47:22AM +0200, Daniel Vetter wrote: > > > This reverts commit 118182e9d7d5afa0c7c10f568afb46ab78b462e9. > > > > > > It's causing too much trouble when compile-testing for non-i915 folks. > > > > What's the argument against using COMPILE_TEST as a proxy for detecting > > all(yes|mod)config as in Damien's patch? > > I also thought about random users bisecting who'll then also might trip > over this. Figure that overall the benefit isn't good enough given the > trouble this seems to have caused immediately. 0-day is pretty fast at > screaming around about new compiler warnings anyway, for the cases where I > miss them. You haven't fixed the issue of breaking a bisect using allyesconfig unless you modify history. Either way they need to do a couple of skips. -Chris -- Chris Wilson, Intel Open Source Technology Centre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/