Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751964AbbEZIoN (ORCPT ); Tue, 26 May 2015 04:44:13 -0400 Received: from mail-ig0-f178.google.com ([209.85.213.178]:35305 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbbEZIoI (ORCPT ); Tue, 26 May 2015 04:44:08 -0400 MIME-Version: 1.0 In-Reply-To: <3919309.jIrkBUJG1x@wuerfel> References: <555BD66A.5020704@nvidia.com> <1432102224-15169-1-git-send-email-acourbot@nvidia.com> <3919309.jIrkBUJG1x@wuerfel> From: Alexandre Courbot Date: Tue, 26 May 2015 17:43:47 +0900 Message-ID: Subject: Re: [PATCH] drm/nouveau/platform: fix compilation if !CONFIG_IOMMU To: David Airlie , Arnd Bergmann Cc: "linux-arm-kernel@lists.infradead.org" , Alexandre Courbot , Ben Skeggs , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , Thierry Reding Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1007 Lines: 24 On Wed, May 20, 2015 at 4:07 PM, Arnd Bergmann wrote: > On Wednesday 20 May 2015 15:10:24 Alexandre Courbot wrote: >> The lack of IOMMU API support can make nouveau_platform_probe_iommu() >> fail to compile because struct iommu_ops is then empty. Fix this by >> skipping IOMMU probe in that case - lack of IOMMU on platform devices >> is sub-optimal, but is not an error. >> >> Signed-off-by: Alexandre Courbot >> --- >> This is an alternative to https://lkml.org/lkml/2015/5/19/484. Most users >> of Nouveau do not care about IOMMU support, so we should not impose that >> option on them. >> > > Yes, good idea. > > Acked-by: Arnd Bergmann Thanks. Dave, are you ok with this patch? If so, can you take it? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/