From: Badola Nikhil <nikhil.badola@freescale.com>
To: Greg KH <gregkh@linuxfoundation.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] drivers:usb:fsl: Replace macros with enumerated type
Thread-Topic: [PATCH] drivers:usb:fsl: Replace macros with enumerated type
Thread-Index: AQHQlq5LMqKwSFs030S/FYzdumGmPZ2M3wiAgADXipA=
Date: Tue, 26 May 2015 09:10:43 +0000
Message-ID: <CY1PR0301MB12574AC2B29F70D9CF0EBB2FF3CC0@CY1PR0301MB1257.namprd03.prod.outlook.com>
References: <1432534294-20375-1-git-send-email-nikhil.badola@freescale.com>
 <20150525161647.GD9772@kroah.com>
In-Reply-To: <20150525161647.GD9772@kroah.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2015 09:10:43.5567
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1257
X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1626;2:soGzxjIQLQzREE7MvLJ8p4KppSOgfXQx7GM/WNjt4HaIXW5NIdn+Uc6+bGDXb4HM;2:zY+BgdSOvLAYHGDRl1KWMk7YyWJc1Z59DULQFXu9iWDeJnn+o1xcZYcnVKRm+szzur8UfEu58baK0LSc4DUwZOlp6xmfOvfIda28HhDslBYNkpCN9VW0MB+VtzsFfkdDWxpXkv2MIoRT0qM3KMrRLA==;9:7w1khO8psPSylfVK2TayJsL3F7fWqwzgIvmzxtgoV6ocry65iuup51VamuAXBYPyyOhi3WmL5r3ZoaPrZmGcpKpHa2hNvJVTOceofEg1mLb1zqWnFw7j846vXUCkn19eV+h/o3vILRoVrL41H8/WbA==
X-OriginatorOrg: freescale.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2035
Lines: 60

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Monday, May 25, 2015 9:47 PM
> To: Badola Nikhil-B46172
> Cc: linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] drivers:usb:fsl: Replace macros with enumerated type
> 
> On Mon, May 25, 2015 at 11:41:34AM +0530, Nikhil Badola wrote:
> > Replace macros with enumerated type to represent usb ip controller
> > version
> >
> > Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> > ---
> > Depends on "drivers: usb :fsl: Add support for USB controller version-2.5"
> >
> >  include/linux/fsl_devices.h | 13 ++++++++-----
> >  1 file changed, 8 insertions(+), 5 deletions(-)
> >
> > diff --git a/include/linux/fsl_devices.h b/include/linux/fsl_devices.h
> > index 2a2f56b..035ead7 100644
> > --- a/include/linux/fsl_devices.h
> > +++ b/include/linux/fsl_devices.h
> > @@ -20,11 +20,6 @@
> >  #define FSL_UTMI_PHY_DLY	10	/*As per P1010RM, delay for UTMI
> >  				PHY CLK to become stable - 10ms*/
> >  #define FSL_USB_PHY_CLK_TIMEOUT	10000	/* uSec */
> > -#define FSL_USB_VER_OLD		0
> > -#define FSL_USB_VER_1_6		1
> > -#define FSL_USB_VER_2_2		2
> > -#define FSL_USB_VER_2_4		3
> > -#define FSL_USB_VER_2_5		4
> >
> >  #include <linux/types.h>
> >
> > @@ -52,6 +47,14 @@
> >   *
> >   */
> >
> > +enum fsl_usb2_controller_ver {
> > +	FSL_USB_VER_OLD,
> > +	FSL_USB_VER_1_6,
> > +	FSL_USB_VER_2_2,
> > +	FSL_USB_VER_2_4,
> > +	FSL_USB_VER_2_5,
> 
> Don't you need to specify the value here just to be "sure" the compiler gets
> it correct, and so that someone knows they can't add a new value in the
> middle?

Will specify the value in the next patch version

> 
> And why didn't you cc: the linux-usb mailing list?

I will cc: linux-usb mailing list while sending all the patches in a patchset
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/