Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752501AbbEZJnH (ORCPT ); Tue, 26 May 2015 05:43:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50392 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752415AbbEZJnE (ORCPT ); Tue, 26 May 2015 05:43:04 -0400 Message-ID: <55644026.6010206@suse.de> Date: Tue, 26 May 2015 11:43:02 +0200 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "Nicholas A. Bellinger" , target-devel CC: linux-scsi , linux-kernel , Christoph Hellwig , Sagi Grimberg , "Paul E. McKenney" , Nicholas Bellinger Subject: Re: [PATCH-v2 0/4] target: Eliminate se_port + t10_alua_tg_pt_gp_member References: <1432623445-25776-1-git-send-email-nab@daterainc.com> In-Reply-To: <1432623445-25776-1-git-send-email-nab@daterainc.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1821 Lines: 50 On 05/26/2015 08:57 AM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi all, > > Here is v2 series with HCH's recent changes to go ahead and drop > all se_port + t10_alua_tg_pt_gp_member usage within target-core in > favor of direct se_lun pointer dereference. > > This includes the original patch + minor fixes, along with two other > improvements for killing off se_lun->lun_sep_lock via RCU pointer > access, and converting the remaining se_lun->lun_active busy-wait > special cases to existing percpu se_lun->lun_ref access. > > Also included in the series is a recently discussed change to go > ahead and drop an unnecessary core_tpg_register() parameter, and > all associated target_core_fabric_ops forward declartions within > fabric driver code. > > The changes since -v1 include: > > - Move ->lun_se_dev assignments under se_device->se_port_lock > - All proper call_rcu() in backend drivers to allow for read-side > critical se_device RCU to complete > - Add se_device->hba_index to clean up RCU dereferences within > scsi_port_show_attr_inst() + scsi_tgt_port_show_attr_inst() > - Add various rcu_dereference and lockless_dereference RCU notation > > Please review. > > --nab > For the whole series: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N?rnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/