Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752535AbbEZJol (ORCPT ); Tue, 26 May 2015 05:44:41 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:56499 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbbEZJoi (ORCPT ); Tue, 26 May 2015 05:44:38 -0400 Date: Tue, 26 May 2015 10:44:22 +0100 From: Mark Brown To: Takashi Iwai Cc: "Maciej S. Szmigiero" , "alsa-devel@alsa-project.org" , linux-kernel , patches@opensource.wolfsonmicro.com, Liam Girdwood , Jaroslav Kysela , Lars-Peter Clausen , Daniel Mack , Wolfram Sang , Charles Keepax , Matt Reimer Message-ID: <20150526094422.GI21577@sirena.org.uk> References: <5560AB9D.1010807@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="67L3nkltNbzPAvlZ" Content-Disposition: inline In-Reply-To: X-Cookie: Positively no smoking. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1399 Lines: 42 --67L3nkltNbzPAvlZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 26, 2015 at 07:29:57AM +0200, Takashi Iwai wrote: > Maciej S. Szmigiero wrote: > > Found out by sparse on 0-day kernel tester. > Wow, that made me wonder how these drivers could actually work. AFAICT the bits were being set by being ored in from the sequential values. > BTW, how did you detect it? Any static analyzer like sparse or > smatch? sparse didn't detect it at the last time I tried, IIRC... Commit log says sparse. --67L3nkltNbzPAvlZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVZEB1AAoJECTWi3JdVIfQoYAH/R8qifIhxg3A7I0iS21tnnW6 lRp2JcWBHWY/2zF2cn9jl9ocVC2SGqA+VUXcA6NkduSSwUWuQzqK9frmaIG2I1Sk hYh1faw1b4f2J1gDSWYxxRbVFy0HZTtUbQYwXkybhVpOjilg2PRMJSJ4bYQJbEe4 KvCH6t+WNwd2KYrtxfitJHNyrHG2xNEOcG/q05VceZmqCQYan652K6iROaRPzd+B UbMwSIyWyISnAT0XBjDdXsPcnkCeWpREX0bSDSOsvRQLe3wuQXSpPHtKYxJp1KBM jQbbCU9QN0oH963Om0rNGzKTjomb/jImX9KWejD/Y6KTvQ+xuK92fOnyxtYxMNg= =vLCk -----END PGP SIGNATURE----- --67L3nkltNbzPAvlZ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/