Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755327AbbEZOBm (ORCPT ); Tue, 26 May 2015 10:01:42 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:62502 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754022AbbEZOBl (ORCPT ); Tue, 26 May 2015 10:01:41 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Alexandre Belloni , Nicolas Ferre , Mark Brown , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ASoC: atmel: compile pcm driver in snd-soc-atmel_ssc_dai Date: Tue, 26 May 2015 12:53:52 +0200 Message-ID: <4338609.rFs5DCIUWR@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1432591459-22613-2-git-send-email-alexandre.belloni@free-electrons.com> References: <1432591459-22613-1-git-send-email-alexandre.belloni@free-electrons.com> <1432591459-22613-2-git-send-email-alexandre.belloni@free-electrons.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:20l9EEaY2IsKrCwn/xC+8C2f91ktnDZa5w5ayg39ThARcx3zj1c AHCBoF/a5X1OYFKLNQ7KgsxFqErmAsMH9XJHgVweYuNceyoxWynphPb6s4gfngEVNNHQGw8 q0wPcZCOwLrclhsL1b6YZ5gSVQwwQua+4/wW+9CXjq8UX7jYOCyVzQXbxw8N1rV/BbXwmUS 91Fcpc9lnDtdaFjPLO1lA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1141 Lines: 28 On Tuesday 26 May 2015 00:04:19 Alexandre Belloni wrote: > index b327e5cc8de3..4fa7ac91f972 100644 > --- a/sound/soc/atmel/Makefile > +++ b/sound/soc/atmel/Makefile > @@ -1,10 +1,8 @@ > # AT91 Platform Support > -snd-soc-atmel-pcm-pdc-objs := atmel-pcm-pdc.o > -snd-soc-atmel-pcm-dma-objs := atmel-pcm-dma.o > -snd-soc-atmel_ssc_dai-objs := atmel_ssc_dai.o > +snd-soc-atmel-pcm-$(CONFIG_SND_ATMEL_SOC_PDC) := atmel-pcm-pdc.o > +snd-soc-atmel-pcm-$(CONFIG_SND_ATMEL_SOC_DMA) += atmel-pcm-dma.o > +snd-soc-atmel_ssc_dai-objs := atmel_ssc_dai.o $(snd-soc-atmel-pcm-y) While technically correct, you could have written this (slightly) simpler as: snd-soc-atmel_ssc_dai-objs := atmel_ssc_dai.o snd-soc-atmel-ssc_dai-$(CONFIG_SND_ATMEL_SOC_PDC) += atmel-pcm-pdc.o snd-soc-atmel-ssc_dai-$(CONFIG_SND_ATMEL_SOC_DMA) += atmel-pcm-dma.o No need to change the patch again after it's applied now. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/