Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755150AbbEZNnY (ORCPT ); Tue, 26 May 2015 09:43:24 -0400 Received: from mail-by2on0125.outbound.protection.outlook.com ([207.46.100.125]:63776 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755121AbbEZNnU (ORCPT ); Tue, 26 May 2015 09:43:20 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; lists.ozlabs.org; dkim=none (message not signed) header.d=none; Date: Tue, 26 May 2015 19:02:48 +0800 From: Zidan Wang To: Nicolin Chen CC: Fabio Estevam , Mark Brown , "Fabio Estevam" , "alsa-devel@alsa-project.org" , linux-kernel , Liam Girdwood , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_spdif: Don't try to round-up for clock divisor calculation Message-ID: <20150526110246.GA13725@shlinux2> References: <1432455161-4924-1-git-send-email-nicoleotsuka@gmail.com> <20150525115812.GG21391@sirena.org.uk> <20150525151127.GA8184@Asurada> <20150525152424.GA8164@Asurada> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150525152424.GA8164@Asurada> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD009;1:5cE2CdNeTRHXzGHMsgW+EGLHSrsCGe9X2vHIEk0DP2YxFDhGOGJwobcwKR7jKnIwhVTzt+AQUfSBrgu/C0wLBUezSDLtjryNR+Ld7I7qMzo5ftEC7kGHab+ufXbPbRh63Ngd/UuVIzdWthwGosKvFnUvxwny0SRu6xE1f7Z1iiDkgfSrlB/TjOxj4yqIJD4iTf/dNru1LQl2roRVgjNkzZ6e7jMPeeGO6HK6xigTroshUkYkCPwHQMcP13qknpH0KMzRwne86p7ubOcijujkHFpEUmqCyczr9N4DcexftLfdfHnTj1nLeFwo9L2c88d742sCslxlfEZ0jdDkT+ltPQ== X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(339900001)(199003)(24454002)(377454003)(189002)(51704005)(19580405001)(86362001)(19580395003)(105606002)(33656002)(54356999)(50986999)(76176999)(85426001)(6806004)(33716001)(87936001)(62966003)(77156002)(2950100001)(83506001)(97756001)(106466001)(104016003)(50466002)(46102003)(47776003)(64706001)(1411001)(93886004)(5001860100001)(5001830100001)(92566002)(77096005)(68736005)(110136002)(5001960100002)(189998001)(4001540100001)(46406003)(97736004)(4001350100001)(23726002)(81156007);DIR:OUT;SFP:1102;SCL:1;SRVR:BN1PR03MB249;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB249;2:TE4++wvjAT0vUWoSOAEPn0Fczqt+dPAqJtxruD296boG+Uv0doAxABRdpiYW+Hb6;2:+cynS9lg21BQnpOWT+ODoN5CG4criyDeWWVR6Z+1rERBY+3tOSsiju9Qdk7YuC2ijhhxTVrJWTDk1HmVjdinLofbOtceGCpSWN+V1mQrCmAD0V0fJ/F9lX5Sf8gg44VzqsjvdHAqpnzfDqeA5HNcr2E3ToH1CHYHr0amWS7ONbe8cRh7/IwxtdMw70Eqfmv0P7T5FGm6UXk254pRhw1OjSkMb1XBuqZu6gMAOa/6SDg=;6:hNbxOTR2IGfe7upOOX3wUEhWTexNcWyJThaHctj4//LY/w0vZGG+NQmZMNXJiE3H0LY4w+ETLI0NxEdnXTjYjd6bFmJGEqiwmre1xSXk1Xf5Lweh0rXtb10ER73cc04DQQhGrNSJ/HhbhJVsjFgXSQ1Ts/u3r3DKOjyQf2zBxTZpHS2Os84hrp8HOpdEeRqJ03uCcFNb1tghceQ5EVbeoJlgdLSw2HCK+1WHz2zxsxnHyH7UxuKsYmnH1QGkdWmw2OfzxsXVvCH4F5pj+0LbfiAUo448KBPpViV2qVMgXHidexSAc5HtlaGQbr7MOn1yjyJy+v5MSu2IuWC5sN6zAw==;3:T9qcLPPHVwvxsuKehBX39UJX7oZYTPc9o2SM9Vk5ayZOrv2Z1ItSHkcvYDhYRFIhusVL4R6rBaOsImnFZZgs64ptQlvWkIwfEX5+dalHCzHlwiIeJYuNJgrDIAJIGZQ102g5EHlIY2VPFTrUFE9Yv54WkPrlhzOjLkQeuoNYS1XzsrngzlWPS/IINF9k1a0oSixCDbM4wmsV4YoVD4f57MZdRHUu8Sc3Dz6rFrDegn0pC307UyVZQliXriyXpx2Njwdxz4G9LLYe5fTCbjcBPqA2J/FKb3KBvll2tepjODoOsylwW8bKtkK2lG+o2u9K X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1PR03MB249; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(520002)(3002001);SRVR:BN1PR03MB249;BCL:0;PCL:0;RULEID:;SRVR:BN1PR03MB249; X-Forefront-PRVS: 0588B2BD96 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN1PR03MB249;9:DFFpKrUZEPeARBS9BFh160N1LoGKyOTHquwUYyjuzIX?= =?us-ascii?Q?4QLv3WRcl+RmZhHLP7iZIeBl6P8r2UNFIRcrlyzbIAURFWXag7OAdQkutxxq?= =?us-ascii?Q?CC01Rm8x4s9TiKcYGpVpFKhyFFYNnkdxe4R55UovUHTq5hzd0HoyHfu4h6Ma?= =?us-ascii?Q?2tO8kDa4IBasgCOx50w+cLxu2giqas8MWPR3hT4GQVok6t9Zzs/tEB3fJyMJ?= =?us-ascii?Q?qwu+JX6qTSFZf7ZpzxhykyVsti8aaYiB7w+tNHGYy6WTwlnjxJD4d9Nkd3Gx?= =?us-ascii?Q?/F2f/Q7sAhzKDxLX2kx+X+BsWuG7zeb8UMNMM/AolGyuKfqdLtASf2QDjuRO?= =?us-ascii?Q?nWGOjR264M6TFceTNhxalWJo/CsbI1fEVKtLHJkW4ec6NUUVKvNJ1XOECU5p?= =?us-ascii?Q?6I5HTQe4hzOnSZpL7VZKkFa+F0Y3/sBJjXUqjIzraZfQA/ZasVeXp6foUCWr?= =?us-ascii?Q?hv2fmy46l4UgsO7rg7xB/SsUyERDPjve3pDlsQplfdRvHdyLLPGxv35S3zNN?= =?us-ascii?Q?PvDapkfpjRsGcCRLMz8Qd4KM/53EH/m5pMszruot2//xU5r8kUFDqeCg20jW?= =?us-ascii?Q?15a8bc98E53QGtTd1ExEFWEjQF2R4WpataErm8fwYQk191h84BkMBXoE4VuK?= =?us-ascii?Q?YZQqhs/P8ur6Wgt+RZ55f7MWYaB8+msEd3oFEPqbBkHdUZEwCJ1OMcDwKAJO?= =?us-ascii?Q?InAnCSwDUZX++4MPmfYgAbAkNEoEoEwUw1CaIfdV/Cy2KAusZtknu0bq3xpN?= =?us-ascii?Q?3vlQQ8wTpY3nZgokJqkNvahcEZmfO4gP2avLwaAdOme08YXOMLimWAu9uIre?= =?us-ascii?Q?VP3Lqc8pjut+I3JtPIqHje5awcK1YfKsVh1qwssk/IS6epYR8n77v6IlzLca?= =?us-ascii?Q?CDEgS+K34tRYXmxTo3oIDt9olYsC3jjEMIbC+zOdnE2v2Jv7gffFbSJidiIc?= =?us-ascii?Q?ImYOZItxPiLX4XItkNKIfe5lzRCCYFpuL5ZmJyH6US4SoFWHF/GBiZsR6aS3?= =?us-ascii?Q?pGFnXFQM42QhTybe49Oy/ZTxe+TX5PTkAWd77Mp2lkWvVjsnsbXr2YOzlI3f?= =?us-ascii?Q?0YHI8kDPWr9iFo0NeFUCsq7OJ6WdqybNQ8+eYfdqFqsduFtCRPVdO/1N/nQv?= =?us-ascii?Q?vwdzq3klJmNqRTBtpthmJBceSAtV3C1/S1cJi0CgM7nJVVx/cYnycMT//SIG?= =?us-ascii?Q?eBenRTXZbe1Sj+1fSkKimjJhpdTqWPGek?= X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB249;3:xv8XHy+cN0M42Wc1DRXNkw6cqjwld2gu5zQTQoOmyjl8HNdvonhAMfTaagrHYh1Q43+TjqQOOk/kIRg49nJJM4Uod/kZH3VI1WOMGtePdozJZvJlmI2oaeayCa65Y8tX7R1MVoXwR3iRNHSYg9bLbw==;10:QmsKX1T3ewxA7gZr0QlVObZItw1t+86lIQ8h57vLLGaNnxIH0r5T2i51tkydev3dGkf2hTxAsv36iRjhH25lbt+LHXDj8v7SStFk7P1Om9c=;6:DGf+LQePDEftGCUSoqnsGZ9xd6Om6hLpn4GZ4/r+PHdU75vcmdVL8ZpGB8r63YCD X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2015 11:03:46.4440 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR03MB249 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1339 Lines: 33 On Mon, May 25, 2015 at 08:24:25AM -0700, Nicolin Chen wrote: > On Mon, May 25, 2015 at 12:13:45PM -0300, Fabio Estevam wrote: > > Hi Nicolin, > > > > On Mon, May 25, 2015 at 12:11 PM, Nicolin Chen wrote: > > > > > Hi Mark, > > > > > > Is that possible for you to provisionally revert this patch? > > > I wanted to wait for the test result from Fabio or Zidan in > > > the Cc list because I don't have a test environment for SPDIF > > > even though this change seems to make sense. > > > > I currently don't have access to a SPDIF receiver to test it. > > Okay, let's wait for Zidan then. We only need to test the > playback route of supporting sample rates. > > Thanks > Nicolin I don't have the board which supported by community to test spdif out. So i used the imx7 board and test it with internal branch. I found that (txclk_df + 1) is better than txclk_df. I suspect the patch for clk_round_rate() is not in our branch. Could you please tell me which patch is for clk_round_rate? I want to cherry-pick it to our branch and test it. Best Regards, Zidan Wang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/