Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753025AbbEZLEi (ORCPT ); Tue, 26 May 2015 07:04:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55869 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752989AbbEZLEh (ORCPT ); Tue, 26 May 2015 07:04:37 -0400 Date: Tue, 26 May 2015 13:04:35 +0200 Message-ID: From: Takashi Iwai To: Jie Yang Cc: broonie@kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com, vivian.zhang@intel.com Subject: Re: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced memory footprint In-Reply-To: <1432638265-16646-2-git-send-email-yang.jie@intel.com> References: <1432638265-16646-1-git-send-email-yang.jie@intel.com> <1432638265-16646-2-git-send-email-yang.jie@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1827 Lines: 66 At Tue, 26 May 2015 19:04:24 +0800, Jie Yang wrote: > > For some embedded devices, we need reduce code size and data > footprint as much as possible, e.g. disabling procfs, hw/sw > params refinement, mmap, dpcm, dapm, compressed API... > > Here add root config menu for those configuration, and > disable procfs once reduced memory footprint is selected. > > Signed-off-by: Jie Yang > --- > sound/Kconfig | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/sound/Kconfig b/sound/Kconfig > index 5a240e0..6760dfa 100644 > --- a/sound/Kconfig > +++ b/sound/Kconfig > @@ -68,6 +68,22 @@ menuconfig SND > > if SND > > +menuconfig SND_REDUCED_MEMORY_FOOTPRINT > + bool "Reduced Memory Footprint Support" > + default n > + help > + Say 'Y' to enable Reduced Memory Footprint Support, which may > + reduce code size and data footprint as much as possible. I'd like to move this into sound/core. Also, the kconfig name appears a bit too lengthy to me. > +config SND_PROC_FS > + bool "Sound Proc FS Support" > + depends on PROC_FS && !SND_REDUCED_MEMORY_FOOTPRINT This should be bool "Sound Proc FS Support" if !SND_REDUCED_MEMORY_FOOTPRINT depends on PROC_FS In this way, this prompt would appear only when SND_REDUCED_MEMORY_FOOTPRINT is set, i.e. only for experts. thanks, Takashi > + default y > + help > + Say 'N' to disable Sound proc FS, which may reduce code size about > + 9KB on x86_64 platform. > + If unsure say Y. > + > source "sound/core/Kconfig" > > source "sound/drivers/Kconfig" > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/