Date: Tue, 26 May 2015 09:04:08 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: lockdep warning: threadirqs and preemptoff tracer
Message-ID: <20150526090408.73eb8499@gandalf.local.home>
In-Reply-To: <55646C50.7070106@bmw-carit.de>
References: <555C49D8.8030009@bmw-carit.de>
	<55645E62.2070507@bmw-carit.de>
	<20150526083215.28f3374b@gandalf.local.home>
	<55646C50.7070106@bmw-carit.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 741
Lines: 20

On Tue, 26 May 2015 14:51:28 +0200
Daniel Wagner <daniel.wagner@bmw-carit.de> wrote:


> > Don't you want to modify __local_bh_enable_ip()?
> 
> __do_softirq() calls __local_bh_disable_ip() and __local_bh_enable() and
> not __local_bh_enable_ip(). I have no clue why this is done this way.
> Need to look into the history.

Yeah, that probably needs to be fixed. Find out why we call *_ip() and
it would make more sense to make that symmetric, as it may break
something else otherwise.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/